Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need proxy label #258

Closed
nguyenhuukhoi opened this issue Nov 24, 2023 · 9 comments
Closed

Need proxy label #258

nguyenhuukhoi opened this issue Nov 24, 2023 · 9 comments

Comments

@nguyenhuukhoi
Copy link
Contributor

nguyenhuukhoi commented Nov 24, 2023

Hello guys.

Could we add proxy labels for this driver?
It will be a nice feature.

I am trying understand our code.

Thank you.

@nguyenhuukhoi
Copy link
Contributor Author

This can achieve by add openstack user-config when we launch instances. Could you give some keywords to code this function. I cannot find location which I inspect this option.

@mnaser
Copy link
Member

mnaser commented Nov 25, 2023

@ngyenhuukhoi do you mean you want the VMs to be created would have an HTTP proxy configured on them? (Curious if @jrosser is interested by it)

@nguyenhuukhoi
Copy link
Contributor Author

nguyenhuukhoi commented Nov 25, 2023

yes, it looks like we cannot deploy magnum cluster under proxy. I have to add http proxy for containerd to images first and it is not flexible.

@jrosser
Copy link
Contributor

jrosser commented Nov 27, 2023

I did a bunch of work to the heat driver in the past to support deployment of workload clusters behind a proxy server.

That said, I've not looked at this at all for magnum-cluster-api and whilst I can use a local registry to prove that the workload cluster deployment is successful behind a proxy this fairly obviously leaves users with a functional but unusable cluster.

@nguyenhuukhoi
Copy link
Contributor Author

Hello.
Does insecure registry still can use with this driver?

@jrosser
Copy link
Contributor

jrosser commented Dec 18, 2023

@mnaser I think that this issue needs re-opening.

A systemd drop-in for containerd which sets http/https_proxy environment, potentially also no_proxy for anything specified in container_infra_prefix will likely get things to the point where a workload cluster deployment will succeed behind an https proxy.

With certainty, the most wrong thing to do would be set proxy environment vars in /etc/environment, as this breaks absolutely everything about the https traffic internal to the cluster.

There is a question about how far to take this, such as also dropping proxy config for apt.

@nguyenhuukhoi
Copy link
Contributor Author

Hello. Any updates on this.

@mnaser
Copy link
Member

mnaser commented Mar 31, 2024

@nguyenhuukhoi this has been fixed by #281 thanks to @andrewbonney ! :)

@mnaser mnaser closed this as completed Mar 31, 2024
@nguyenhuukhoi
Copy link
Contributor Author

nguyenhuukhoi commented Mar 31, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants