Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use hygiene_with_config instead of hygiene #8848

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 26, 2024

Description

Testing Instructions

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 2:14am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 2:14am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 2:14am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 2:14am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 2:14am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 2:14am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 2:14am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 2:14am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 2:14am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 2:14am

Copy link
Contributor

github-actions bot commented Jul 26, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jul 26, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kdy1 kdy1 self-assigned this Jul 29, 2024
@kdy1 kdy1 marked this pull request as ready for review July 29, 2024 02:12
@kdy1 kdy1 requested a review from a team as a code owner July 29, 2024 02:12
@kdy1 kdy1 changed the title add test case for swc renaming bug fix: Use hygiene_with_config instead of hygiene Jul 29, 2024
@sokra sokra merged commit aeecec6 into main Jul 29, 2024
58 of 60 checks passed
@sokra sokra deleted the sokra/module-eval-bug branch July 29, 2024 06:05
"use strict";
return eval("module");
};
function moduleFunciton(module) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moduleFunciton -> moduleFunction

ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…#8848)

### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

---------

Co-authored-by: 강동윤 (Donny) <[email protected]>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…#8848)

### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

---------

Co-authored-by: 강동윤 (Donny) <[email protected]>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…#8848)

### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

---------

Co-authored-by: 강동윤 (Donny) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants