Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable rust codepath on CI #6449

Merged
merged 12 commits into from
Nov 15, 2023

Conversation

chris-olszewski
Copy link
Member

@chris-olszewski chris-olszewski commented Nov 14, 2023

Description

This PR switches to use the Rust codepath for turborepo CI.

Part of this PR switches our Windows usage to use GitBash instead of Powershell for invoking turbo. This isn't ideal, but it allows us to start dogfooding.

Testing Instructions

Our existing CI should pass. We should eagerly revert if an issue is discovered.

Closes TURBO-1665

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 10:20pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 10:20pm
examples-nonmonorepo 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 10:20pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 10:20pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 10:20pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 10:20pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 10:20pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 10:20pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 10:20pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 10:20pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 10:20pm

Copy link
Contributor

github-actions bot commented Nov 14, 2023

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Nov 14, 2023

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Nov 14, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (linux)
  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@chris-olszewski chris-olszewski marked this pull request as ready for review November 15, 2023 22:37
@chris-olszewski chris-olszewski requested review from a team as code owners November 15, 2023 22:37
Copy link
Contributor

@gsoltis gsoltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

@chris-olszewski chris-olszewski merged commit 0d72ef5 into main Nov 15, 2023
59 of 65 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/chore_dogfood_rust_on_ci branch November 15, 2023 23:34
chris-olszewski added a commit that referenced this pull request Nov 16, 2023
### Description

I realized I forgot to move e2e to use bash instead of powershell as I
did with the other windows jobs in #6449

This is causing the network failures on PRs e.g.
https://github.com/vercel/turbo/actions/runs/6885178823/job/18729263113?pr=6473#step:4:24

### Testing Instructions

e2e windows tests should pass on this PR


Closes TURBO-1683

Co-authored-by: Chris Olszewski <Chris Olszewski>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants