-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable rust codepath on CI #6449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
✅ This change can build |
|
gsoltis
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFG
chris-olszewski
added a commit
that referenced
this pull request
Nov 16, 2023
### Description I realized I forgot to move e2e to use bash instead of powershell as I did with the other windows jobs in #6449 This is causing the network failures on PRs e.g. https://github.com/vercel/turbo/actions/runs/6885178823/job/18729263113?pr=6473#step:4:24 ### Testing Instructions e2e windows tests should pass on this PR Closes TURBO-1683 Co-authored-by: Chris Olszewski <Chris Olszewski>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches to use the Rust codepath for turborepo CI.
Part of this PR switches our Windows usage to use GitBash instead of Powershell for invoking
turbo
. This isn't ideal, but it allows us to start dogfooding.Testing Instructions
Our existing CI should pass. We should eagerly revert if an issue is discovered.
Closes TURBO-1665