fix: move e2e to use bash to match other jobs #6474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 11 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
tknickman
approved these changes
Nov 16, 2023
mehulkar
approved these changes
Nov 16, 2023
|
✅ This change can build |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I realized I forgot to move e2e to use bash instead of powershell as I did with the other windows jobs in #6449
This is causing the network failures on PRs e.g. https://github.com/vercel/turbo/actions/runs/6885178823/job/18729263113?pr=6473#step:4:24
Testing Instructions
e2e windows tests should pass on this PR
Closes TURBO-1683