Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Check for /etc/debian_version (0.8.x) #805

Conversation

BenjamenMeyer
Copy link
Member

Code Changes:

Issues:

Purpose:

  • What is this pull request trying to do?
    Check that /etc/debian_version exists Before relying on it existing.

NOTE: The logic was originally setup for Debian distros; however, when run on a non-Debian distro with the Debian Packaging tools installed this file does not exist and in some cases it can cause a problem.

Check that /etc/debian_version exists Before relying on it
existing.

NOTE: THe logic was originally setup for Debian distros; however,
when run on a non-Debian distro with the Debian Packaging tools
installed this file does not exist and in some cases it can cause
a problem.
Copy link
Contributor

@royfalk royfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@royfalk royfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabioLolix
Copy link

I tested this is working

@BenjamenMeyer
Copy link
Member Author

Regarding the failed CI issues:

  • they're not related to the change here
  • the Windows one is due to Compiler settings not being properly segrated, MSVC doesn't support two that got specified
  • the Manjaro ones are due to a string and int concat via str+int which isn't legal.
    Let's address those in separate PRs.

@BenjamenMeyer BenjamenMeyer merged commit beff0dd into vegastrike:0.8.x Oct 29, 2023
39 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants