Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Windows Build on 0.8.x #807

Merged

Conversation

BenjamenMeyer
Copy link
Member

Code Changes:

Issues:

Purpose:

  • What is this pull request trying to do? Fix the Windows CI builds for 0.8.x
  • What release is this for? 0.8.x
  • Is there a project or milestone we should apply this to? 0.8.x

Compiler specification is wrong.
@BenjamenMeyer BenjamenMeyer added this to the 0.8.x milestone Oct 29, 2023
@BenjamenMeyer BenjamenMeyer self-assigned this Oct 29, 2023
@BenjamenMeyer
Copy link
Member Author

BenjamenMeyer commented Oct 29, 2023

NOTE: The Manjaro build will fail on this one. That will be fixed by #808 .

@BenjamenMeyer
Copy link
Member Author

Windows build no longer fails due to compiler setting. It is still failing for other issues.
This fixes the issue it set out to fix; we don't exactly support Windows on 0.8.x so new issue - which seems to be about including config.h is fine to leave alone.

Copy link
Contributor

@stephengtuggy stephengtuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch.

@BenjamenMeyer BenjamenMeyer merged commit 6906435 into vegastrike:0.8.x Nov 11, 2023
39 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants