Node: add ZINTER and ZUNION commands #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TJ Zhang <[email protected]>
tjzhang-BQ
force-pushed
the
node/integ-tjz-VALKEY-62-zunion
branch
from
1d6c498 to
a7ed20f
Compare
acarbonetto
reviewed
Aug 15, 2024
node/src/Transaction.ts
Outdated
| @@ -1871,6 +1873,8 @@ export class BaseTransaction<T extends BaseTransaction<T>> { | |||
| * | |||
| * @see {@link https://valkey.io/commands/zinterstore/|valkey.io} for details. | |||
| * | |||
| * since Valkey version 6.2.0. | |||
There was a problem hiding this comment.
Suggested change
| * since Valkey version 6.2.0. | |
| * @remarks Since Valkey version 6.2.0. |
Signed-off-by: TJ Zhang <[email protected]>
node/tests/SharedTests.ts
Outdated
| async (protocol) => { | ||
| await runTest(async (client: BaseClient, cluster: RedisCluster) => { | ||
| if (cluster.checkIfServerVersionLessThan("6.2.0")) return; | ||
| await zunionBasicTest(client); |
There was a problem hiding this comment.
upvoting to split into multiple tests
acarbonetto
approved these changes
Aug 16, 2024
node/src/Commands.ts
Outdated
| */ | ||
| function createZCmdArgs( | ||
| keys: string[] | KeyWeight[], | ||
| aggregationType?: AggregationType, |
There was a problem hiding this comment.
nit - change this to use an anonymous object to define the 3 optional variables:
function createZCmdArgs(
keys: string[] | KeyWeight[],
options: {aggregationType: string?, withscores: boolean?, destination: string? }
): string[] {
Signed-off-by: TJ Zhang <[email protected]>
GumpacG
approved these changes
Aug 19, 2024
Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: jonathanl-bq <[email protected]>
Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: Jonathan Louie <[email protected]>
GumpacG
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original PR: #1556