Node: ZINTER and ZUNION commands #1556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
requested changes
Jun 12, 2024
| client.zinterstore("abc", ["zxy", "lkn"]), | ||
| client.zunion(["abc", "zxy", "lkn"]), | ||
| client.zunionWithScores(["abc", "zxy", "lkn"]), |
There was a problem hiding this comment.
nit: add with version check (see line 304)
Signed-off-by: Adar Ovadia <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
Comment on lines
+3109
to
+3110
| * string[] - for keys only. | ||
| * KeyWeight[] - for weighted keys with score multipliers. |
There was a problem hiding this comment.
Can you format this as a list please?
| @@ -772,6 +774,22 @@ export async function transactionTest( | |||
| responseData.push(['zmscore(key12, ["two", "one"]', [2.0, 1.0]]); | |||
| baseTransaction.zinterstore(key12, [key12, key13]); | |||
| responseData.push(["zinterstore(key12, [key12, key13])", 0]); | |||
| baseTransaction.zadd(key25, { one: 1, two: 2 }); | |||
acarbonetto
reviewed
Aug 14, 2024
tjzhang-BQ
reviewed
Aug 16, 2024
There was a problem hiding this comment.
Created a new PR with the changes to both rebase and address comments #2146
|
Closing as #2146 took its place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.