Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: add GETEX #1609

Merged
merged 17 commits into from
Jun 20, 2024
Merged

Java: add GETEX #1609

merged 17 commits into from
Jun 20, 2024

Conversation

cyip10
Copy link
Collaborator

@cyip10 cyip10 commented Jun 19, 2024

Issue #, if available:
https://redis.io/docs/latest/commands/getex/

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cyip10 cyip10 requested a review from a team as a code owner June 19, 2024 18:49
@cyip10 cyip10 force-pushed the java/integ_cyip10_getex branch 2 times, most recently from de61e78 to a1ee4ab Compare June 19, 2024 21:08
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Jun 19, 2024
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming Andrew's comments are addressed

@acarbonetto acarbonetto changed the title Java: add GETEX Java: add GETEX Jun 20, 2024
@acarbonetto acarbonetto merged commit aaa8e45 into valkey-io:main Jun 20, 2024
12 checks passed
@acarbonetto acarbonetto deleted the java/integ_cyip10_getex branch June 20, 2024 22:59
cyip10 added a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
* implement getex options

* current progress

* continue progress on tests

* implement getex

* Address comments

* address more comments

* fix tests

* address final comments

* address remaining comments

* resolve merge conflicts

* ran spotless

* add new tests

* fix tests

* Add initial test for GetExOptions

Signed-off-by: Andrew Carbonetto <[email protected]>

* fix tests

* fix tests

* ran spotless

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Chloe Yip <[email protected]>
Co-authored-by: Chloe Yip <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants