fix tests

valkey-io · Jun 20, 2024 · 64a3eb8 · 64a3eb8
1 parent 089b459
commit 64a3eb8
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 22 deletions.
diff --git a/java/client/src/main/java/glide/api/models/commands/GetExOptions.java b/java/client/src/main/java/glide/api/models/commands/GetExOptions.java
@@ -105,7 +105,7 @@ public String[] toArgs() {
         if (count != null) {
             optionArgs.add(String.valueOf(count));
         }
-
+        System.out.println(optionArgs);
         return optionArgs.toArray(new String[0]);
     }
 }
diff --git a/java/client/src/test/java/glide/api/RedisClientTest.java b/java/client/src/test/java/glide/api/RedisClientTest.java
@@ -546,33 +546,34 @@ public void getex() {
 
     private static List<Arguments> getGetExOptions() {
         return List.of(
-            Arguments.of(
-                // desc...
-                "test_with_seconds",
-                GetExOptions.Seconds(10L),
-                new String[] {"EX", "10"}
-            )
-        );
+                Arguments.of(
+                        // seconds
+                        "test_with_seconds", GetExOptions.Seconds(10L), new String[] {"EX", "10"}),
+                Arguments.of(
+                        // milliseconds
+                        "test_with_milliseconds",
+                        GetExOptions.Milliseconds(1000L),
+                        new String[] {"PX", "1000"}),
+                Arguments.of(
+                        // unix seconds
+                        "test_with_unix_seconds", GetExOptions.UnixSeconds(10L), new String[] {"EXAT", "10"}),
+                Arguments.of(
+                        // unix milliseconds
+                        "test_with_unix_milliseconds",
+                        GetExOptions.UnixMilliseconds(1000L),
+                        new String[] {"PXAT", "1000"}),
+                Arguments.of(
+                        // persist
+                        "test_with_persist", GetExOptions.Persist(), new String[] {"PERSIST"}));
     }
 
     @SneakyThrows
     @ParameterizedTest(name = "{0}")
     @MethodSource("getGetExOptions")
     public void getex_options(String testName, GetExOptions options, String[] expectedArgs) {
-        assertArrayEquals(expectedArgs, options.toArgs(), "Expected " + testName + " toArgs() to pass.");
-
-        // setup
-//        GetExOptions options1 = GetExOptions.Seconds(10L);
-//        GetExOptions options2 = GetExOptions.Milliseconds(1000L);
-//        GetExOptions options3 = GetExOptions.UnixSeconds(10L);
-//        GetExOptions options4 = GetExOptions.UnixMilliseconds(1000L);
-//        GetExOptions options5 = GetExOptions.Persist();
-
-//        String[] arguments1 = new String[] {"key", "EX", "10"};
-//        String[] arguments2 = new String[] {"key", "PX", "1000"};
-//        String[] arguments3 = new String[] {"key", "EXAT", "10"};
-//        String[] arguments4 = new String[] {"key", "PXAT", "1000"};
-//        String[] arguments5 = new String[] {"key", "PERSIST"};
+        assertArrayEquals(
+                expectedArgs, options.toArgs(), "Expected " + testName + " toArgs() to pass.");
+        System.out.println(expectedArgs);
     }
 
     @SneakyThrows