Update so3.py #13
Open
Update so3.py #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `liegroups` lib I run into the following `SyntaxWarning` when using the `so3.py` file ```bash liegroups/numpy/so3.py:83: SyntaxWarning: "is" with a literal. Did you mean "=="? elif ordering is 'wxyz': ``` I've changed the literal with two equal signs for this file to prevent the warning.
changed literal comparison to equality comparison to prevent `SyntaxWarning` on runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
liegroupslib I run into the followingSyntaxWarningwhen using theso3.pyfileI've changed the literal with two equal signs for this file to prevent the warning. I will look through some of the other files to see if I can find any more needing to be changed.