-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: open tenders screen #16
Open
irony
wants to merge
13
commits into
main
Choose a base branch
from
feat/openTender
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
00bc687
feat: open tenders screen
irony 7767c16
fix: handle loading dis correctly
irony 1edc949
fix: comment out illegal styles
StefanWallin f38a833
feat: create offer
irony 195365d
merge: overflow fix
irony 3ea4cc6
fix: bugfix focus caused endless loop
irony 2315407
feat: layout
irony 02b8b03
chore: remove warnings
irony 83e2ab5
chore: refactor hero
irony 42273e2
feat: reuse hero in createTender
irony 72f4a74
feat: added sliders - with: StefanWallin and md2perpe
irony b372335
fix: prevent div/0
irony 869318d
Merge branch 'main' into feat/openTender
irony File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,28 @@ | ||
import React from 'react' | ||
import {ImageBackground, StyleSheet, View} from 'react-native' | ||
import { ImageBackground, StyleSheet, View } from 'react-native' | ||
import { TouchableOpacity } from 'react-native-gesture-handler' | ||
|
||
const DEFAULT_OVERLAY_COLOR = 'rgba(53,34,171,0.4)' | ||
|
||
export const ImageOverlay = ({style, children, ...imageBackgroundProps}) => { | ||
const {overlayColor, ...imageBackgroundStyle} = StyleSheet.flatten(style) | ||
export const ImageOverlay = ({ | ||
style, | ||
children, | ||
onPress, | ||
...imageBackgroundProps | ||
}) => { | ||
const { overlayColor, ...imageBackgroundStyle } = StyleSheet.flatten(style) | ||
|
||
return ( | ||
<ImageBackground {...imageBackgroundProps} style={imageBackgroundStyle}> | ||
<View | ||
style={[ | ||
StyleSheet.absoluteFill, | ||
{backgroundColor: overlayColor || DEFAULT_OVERLAY_COLOR}, | ||
]} | ||
/> | ||
{children} | ||
</ImageBackground> | ||
<TouchableOpacity onPress={onPress}> | ||
<ImageBackground {...imageBackgroundProps} style={imageBackgroundStyle}> | ||
<View | ||
style={[ | ||
StyleSheet.absoluteFill, | ||
{ backgroundColor: overlayColor || DEFAULT_OVERLAY_COLOR }, | ||
]} | ||
/> | ||
{children} | ||
</ImageBackground> | ||
</TouchableOpacity> | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,17 +9,7 @@ import React from 'react' | |
import { View } from 'react-native' | ||
import { useIssues } from '../hooks/useGithub' | ||
import { ImageOverlay } from './ImageOverlay' | ||
|
||
const tag = (label, index) => ( | ||
<Button | ||
key={index} | ||
style={styles.detailItem} | ||
appearance="outline" | ||
size="small" | ||
> | ||
{label.name} | ||
</Button> | ||
) | ||
import { Tag } from './Tag' | ||
|
||
export const Issues = ({ url, selected, onSelectedChange }) => { | ||
if (!url) return <Text>No repo</Text> | ||
|
@@ -63,7 +53,7 @@ export const Issues = ({ url, selected, onSelectedChange }) => { | |
{issue.body} | ||
</Text> | ||
<View style={styles.tags}> | ||
{issue.labels.map((label, index) => tag(label, index))} | ||
{issue.labels.map((label, index) => <Tag key={index}>{label.name}</Tag>)} | ||
</View> | ||
</View> | ||
</View> | ||
|
@@ -93,7 +83,7 @@ const styles = StyleService.create({ | |
borderRadius: 16, | ||
}, | ||
body: { | ||
overflow: '', | ||
// overflow: '', //ILLEGAL! | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had to do this be able to see the Issues screen on my simulator. |
||
maxHeight: 100, | ||
}, | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import React from 'react' | ||
import { | ||
Button, | ||
Card, | ||
CheckBox, | ||
StyleService, | ||
Text, | ||
} from '@ui-kitten/components' | ||
|
||
export const Tag = ({children}) => ( | ||
<Button | ||
style={styles.tag} | ||
appearance="outline" | ||
size="tiny" | ||
> | ||
{children} | ||
</Button> | ||
) | ||
|
||
|
||
|
||
const styles = StyleService.create({ | ||
tag: { | ||
borderRadius: 16, | ||
}, | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have better error handling here so that we do not crash the app if the API is down. Created issue #17 for it