feat: open tenders screen #16
Conversation
|
Closes #3 |
packages/Upphandling/api/tenders.js
Outdated
| export const getTenders = async () => { | ||
| const { data } = await axios.get('https://api.upphandling.app/tenders') | ||
| export const getTenders = async (disId) => { | ||
| const { data } = await axios.get(`https://api.upphandling.app/dis/${disId}/tenders`) |
There was a problem hiding this comment.
We should have better error handling here so that we do not crash the app if the API is down. Created issue #17 for it
| <View style={styles.tenderHeader}> | ||
| <Text category={'h6'}>{description}</Text> | ||
| <Text category={'c1'}> | ||
| {moment(startDate).calendar()} |
There was a problem hiding this comment.
On moment's website they state the following:
Considering using Moment in your project?
There may be better modern alternatives.
For more details and recommendations,
please see Project Status in the docs.
So it seems to me it's kind of deprecated nowadays and we should consider if we should be using it.
A library that supports this kind of relative dates that isn't moment would be https://sugarjs.com/dates/#/Formatting
| @@ -21,7 +21,7 @@ | |||
| <fontDescription key="fontDescription" type="boldSystem" pointSize="36"/> | |||
| <nil key="highlightedColor"/> | |||
| </label> | |||
| <label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Powered by React Native" textAlignment="center" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" minimumFontSize="9" translatesAutoresizingMaskIntoConstraints="NO" id="MN2-I3-ftu"> | |||
| <label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Sponsored by Iteam" textAlignment="center" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" minimumFontSize="9" translatesAutoresizingMaskIntoConstraints="NO" id="MN2-I3-ftu"> | |||
packages/Upphandling/screens/DIS.js
Outdated
| @@ -176,8 +188,14 @@ export const DIS = ({ navigation, route }) => { | |||
| bottomOffset={350} | |||
| > | |||
| <View style={styles.bottomDrawerContent}> | |||
| <Text category="label" style={styles.footerLabel}>{selected.length} ärenden valda. Gå vidare och skapa upphandling.</Text> | |||
| <Button onPress={() => navigation.navigate('CreateTender', { id, issues: selected })}> | |||
| <Text category="label" style={styles.footerLabel}> | |||
There was a problem hiding this comment.
When this box is active there is also black overlay in top of the list of issues from github. If you want to select 8 github issues you would have to click 15 times. 8 to check boxes and 7 in between to click away the black overlay. Is this on purpose to try and game people into creating smaller DISes or a UX mishap?
| @@ -83,7 +83,7 @@ const styles = StyleService.create({ | |||
| borderRadius: 16, | |||
| }, | |||
| body: { | |||
| overflow: '', | |||
| // overflow: '', //ILLEGAL! | |||
There was a problem hiding this comment.
I had to do this be able to see the Issues screen on my simulator.
overflow only accepts one of these values 'visible', 'hidden', 'scroll'.
Visa specifika upphandlingar i lista:
Navigera till en specifik upphandling:
Skapa ny specifik upphandling från issues:
Definiera nödvändig kompetens inkl nivå på kompetensen:
