Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for markupgo provider in contributors generator #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abdullah
Copy link

Resolves #66

Hi team 🙌

This PR introduces a new provider for the GitHub contributors generator. I have updated the documentation and generators/contributors.ts suggested as issue description.

Here’s a screenshot for a quick review of the documentation update.

screencapture-localhost-4000-generators-contributors-2024-08-14-16_33_43

@abdullah
Copy link
Author

@pi0 I suggest to hide whitespace while reviewing. It is easy to understand what was changed for this PR 🙃

image

@abdullah
Copy link
Author

@pi0 Did you have a chance to review this PR?

@abdullah
Copy link
Author

@pi0 Hi, any update on this PR?

@abdullah abdullah closed this Sep 23, 2024
@pi0
Copy link
Member

pi0 commented Sep 23, 2024

Sorry for late review. Any reason closed it @abdullah ?

@abdullah
Copy link
Author

Ah, @pi0, it was completely closed by mistake. Sorry about that—I’ve re-opened it!

@abdullah abdullah reopened this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support markupgo provider for contributors
2 participants