Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support markupgo provider for contributors #66

Open
1 task
pi0 opened this issue Aug 13, 2024 · 4 comments · May be fixed by #67
Open
1 task

Support markupgo provider for contributors #66

pi0 opened this issue Aug 13, 2024 · 4 comments · May be fixed by #67
Labels
enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Aug 13, 2024

Describe the feature

(context: moving from nitrojs/nitro#2660)

markupgo provides an alternative service to contrib.rocks for generating more frequently update list of contributors.

I think generally thinking even without considering a comparative, we should support multi providers for contributors.

Additional information

  • Would you be willing to help implement this feature?
@pi0 pi0 added the enhancement New feature or request label Aug 13, 2024
@pi0
Copy link
Member Author

pi0 commented Aug 13, 2024

/cc @abdullah if you want to help on this, here is generator source code. We shall support args.provider= 'contrib.rocks' | 'markupgo' (and might support more params if markupgo supports, ideally with a compatible name)

@abdullah
Copy link

@pi0 Yes, I definitely want to contribute it 🤘

@abdullah
Copy link

I'm planning to create a PR to support MarkupGo today 🙌

@abdullah
Copy link

@pi0 Just opened a PR for this issue. #67 Could you please review it when you have time? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants