Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: selectable mixin only be selective when selectabletarget is this #971

Merged
merged 32 commits into from
Nov 27, 2024
Merged

Fix: selectable mixin only be selective when selectabletarget is this #971

merged 32 commits into from
Nov 27, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Nov 26, 2024 •
edited by madsrasmussen
Loading

A different take on the issue fixed by PR #970

This keeps the strictness on who fire a click event if the selectableTarget is this, if its more specific it accepts a broader origin within that scope.

Elements using the SelectableMixin:

  • uui-card
  • uui-color-swatch
  • uui-combobox-list-option
  • uui-menu-item
  • uui-ref
  • uui-table-row

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe changed the title V1/bugfix/selectable mixin only be selective when selectabletarget is this Fix: selectable mixin only be selective when selectabletarget is this Nov 26, 2024
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@nielslyngsoe
Revert "align table row selection"
29a376c 
This reverts commit 976b568.

# Conflicts:
#	packages/uui-table/lib/uui-table-row.element.ts
@nielslyngsoe
optimize code
2bb4b11
@nielslyngsoe
revert to none preventing approach
ef1cbae
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@madsrasmussen
Merge branch 'v1/chore/test-runner-commands' into v1/bugfix/selectabl…
209fbaf 
…eMixin-only-be-selective-when-selectabletarget-is-this
@madsrasmussen
Merge branch 'v1/bugfix/selectableMixin-only-be-selective-when-select…
94e8210 
…abletarget-is-this' of https://github.com/umbraco/Umbraco.UI into v1/bugfix/selectableMixin-only-be-selective-when-selectabletarget-is-this
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@madsrasmussen
test keyboard interaction
5ac142f
@madsrasmussen
Merge branch 'v1/bugfix/selectableMixin-only-be-selective-when-select…
fa65695 
…abletarget-is-this' of https://github.com/umbraco/Umbraco.UI into v1/bugfix/selectableMixin-only-be-selective-when-selectabletarget-is-this
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-971.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe marked this pull request as ready for review November 27, 2024 13:10
@nielslyngsoe nielslyngsoe enabled auto-merge (rebase) November 27, 2024 13:12
This was referenced Nov 27, 2024
Closed
Closed
@iOvergaard iOvergaard disabled auto-merge November 27, 2024 13:33
@iOvergaard iOvergaard enabled auto-merge (squash) November 27, 2024 13:33
@iOvergaard iOvergaard merged commit dc7a416 into v1/contrib Nov 27, 2024
9 of 10 checks passed
@iOvergaard iOvergaard deleted the v1/bugfix/selectableMixin-only-be-selective-when-selectabletarget-is-this branch November 27, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielslyngsoe @iOvergaard @madsrasmussen