Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: allow current element to be the selectable target by default #970

Closed
wants to merge 5 commits into from
Closed

Fix: allow current element to be the selectable target by default #970

wants to merge 5 commits into from

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Nov 26, 2024 •
edited
Loading

Description

We currently have an issue where selection does not work if a selectableTarget is not set to something different than the element itself.

This PR allows the element itself (this) to be selectable if a specific selectableTarget is not specified.

Elements using the SelectableMixin:

  • uui-card
  • uui-color-swatch
  • uui-combobox-list-option
  • uui-menu-item
  • uui-ref
  • uui-table-row

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-970.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe mentioned this pull request Nov 26, 2024
Merged
7 tasks
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-970.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-970.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-970.westeurope.azurestaticapps.net

@madsrasmussen
Copy link
Contributor Author

Replaced by #971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe Awaiting requested review from nielslyngsoe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@madsrasmussen