Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline-button-create: Add href #720

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Inline-button-create: Add href #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ee76fe
add href and target
JesmoDev Jan 23, 2024
f8168bb
Merge branch 'v1/contrib' into feature/inline-button-create-href
iOvergaard Jan 23, 2024
2704134
re position the create-circle
nielslyngsoe Jan 23, 2024
d577df5
no blur and better story
nielslyngsoe Jan 23, 2024
98e11bf
Merge branch 'v1/contrib' into feature/inline-button-create-href
nielslyngsoe Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 64 additions & 18 deletions packages/uui-button-inline-create/lib/uui-button-inline-create.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { defineElement } from '@umbraco-ui/uui-base/lib/registration';
import { css, html, LitElement } from 'lit';
import { property, state } from 'lit/decorators.js';
import { styleMap } from 'lit/directives/style-map.js';
import { ifDefined } from 'lit/directives/if-defined.js';

import { UUIButtonInlineCreateEvent } from './UUIButtonInlineCreateEvent';

Expand Down Expand Up @@ -37,44 +38,89 @@ export class UUIButtonInlineCreateElement extends LitElement {
@property({ type: Boolean, reflect: true })
vertical = false;

/**
* Set an href, this will turns the button into an anchor tag.
* @type {string}
* @attr
* @default undefined
*/
@property({ type: String })
public href?: string;

/**
* Set an anchor tag target, only used when using href.
* @type {string}
* @attr
* @default undefined
*/
@property({ type: String })
public target?: '_blank' | '_parent' | '_self' | '_top';

private _onMouseMove(e: MouseEvent) {
this._position = this.vertical ? e.offsetY : e.offsetX;
this._position = (this.vertical ? e.offsetY : e.offsetX) - 5;
}

private _handleClick(e: MouseEvent) {
e.preventDefault();
e.stopImmediatePropagation();

// We do not want to focus the button after click.
(e.target as any)?.blur?.();

this.dispatchEvent(
new UUIButtonInlineCreateEvent(UUIButtonInlineCreateEvent.CLICK)
);
}

render() {
#renderContent() {
return html`
<div
id="plus"
style=${styleMap({
left: this.vertical ? '' : this._position + 'px',
top: this.vertical ? this._position + 'px' : '',
})}>
<svg
id="plus-icon"
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 512 512">
<path
d="M420.592 214.291H296.104V89.804h-83.102v124.487H88.518v83.104h124.484v124.488h83.102V297.395h124.488z" />
</svg>
</div>
`;
}

#renderLink() {
return html`<a
id="button-wrapper"
@mousemove=${this._onMouseMove}
href=${ifDefined(this.href)}
target=${ifDefined(this.target || undefined)}
rel=${ifDefined(
this.target === '_blank' ? 'noopener noreferrer' : undefined
)}
aria-label=${this.label ? this.label : 'create new element'}>
${this.#renderContent()}
</a>`;
}

#renderButton() {
return html`
<button
id="button-wrapper"
@mousemove=${this._onMouseMove}
@click=${this._handleClick}
aria-label=${this.label ? this.label : 'create new element'}>
<div
id="plus"
style=${styleMap({
left: this.vertical ? '' : this._position + 'px',
top: this.vertical ? this._position + 'px' : '',
})}>
<svg
id="plus-icon"
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 512 512">
<path
d="M420.592 214.291H296.104V89.804h-83.102v124.487H88.518v83.104h124.484v124.488h83.102V297.395h124.488z" />
</svg>
</div>
${this.#renderContent()}
</button>
`;
}

render() {
return this.href ? this.#renderLink() : this.#renderButton();
}

static styles = [
UUIBlinkKeyframes,
css`
Expand Down Expand Up @@ -205,12 +251,12 @@ export class UUIButtonInlineCreateElement extends LitElement {
}

:host(:not([vertical])) #plus {
margin-left: -21px;
margin-left: -18px;
}

:host([vertical]) #plus {
left: -4px;
margin-top: -21px;
margin-top: -18px;
}

#button-wrapper:focus #plus {
Expand Down
75 changes: 67 additions & 8 deletions packages/uui-button-inline-create/lib/uui-button-inline-create.story.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export default {

const insertBox = (e: any) => {
const div = document.createElement('div');
const labelDiv = document.createElement('div');
const label = document.createElement('div');
const buttonInline = document.createElement('uui-button-inline-create');
buttonInline.addEventListener('click', insertBox);
Expand All @@ -33,18 +34,31 @@ const insertBox = (e: any) => {

if (e.target.vertical) {
buttonInline.setAttribute('vertical', 'true');
div.style.display = 'grid';
div.style.gridTemplateColumns = '1fr auto';
labelDiv.style.display = 'grid';
labelDiv.style.gridTemplateColumns = '1fr auto';
buttonInline.style.position = 'absolute';
buttonInline.style.right = '0';
buttonInline.style.top = '0';
} else {
labelDiv.style.display = 'block';
}

div.appendChild(label);
div.appendChild(buttonInline);
labelDiv.appendChild(label);
div.appendChild(labelDiv);

e.target.parentElement.insertAdjacentElement('afterend', div);
e.target.parentElement.parentElement.insertBefore(
div,
e.target.parentElement
);
};

const createBox = (vertical: boolean) =>
html` <div style="position:relative;">
<uui-button-inline-create
style="${vertical ? 'position: absolute; right: 0; top:0;' : ''}"
?vertical=${vertical}
@click=${insertBox}></uui-button-inline-create>
<div
style="
${vertical
Expand All @@ -55,17 +69,21 @@ const createBox = (vertical: boolean) =>
${GetRandomUmbracoWord()}
</div>
</div>
<uui-button-inline-create
style="${vertical ? 'position: absolute; right: 0; top:0;' : ''}"
?vertical=${vertical}
@click=${insertBox}></uui-button-inline-create>
</div>`;

const createBoxes = (count: number, vertical = false) => {
const boxes: TemplateResult<1>[] = [];
for (let index = 0; index < count; index++) {
boxes.push(createBox(vertical));
}
boxes.push(html`
<div style="position:relative;">
<uui-button-inline-create
style="${vertical ? 'position: absolute; right: 0; top:0;' : ''}"
?vertical=${vertical}
@click=${insertBox}></uui-button-inline-create>
</div>
`);
return boxes;
};

Expand All @@ -80,6 +98,7 @@ AAAOverview.parameters = {
source: {
code: `
<div>
<uui-button-inline-create label="Create Item"></uui-button-inline-create>
<div style="padding: 10px;">Item 1</div>
<uui-button-inline-create label="Create Item"></uui-button-inline-create>
<div style="padding: 10px;">Item 2</div>
Expand All @@ -102,6 +121,7 @@ Vertical.parameters = {
source: {
code: `
<div>
<uui-button-inline-create label="Create Item"></uui-button-inline-create>
<div style="padding: 10px;">Item 1</div>
<uui-button-inline-create label="Create Item"></uui-button-inline-create>
<div style="padding: 10px;">Item 2</div>
Expand All @@ -124,6 +144,7 @@ Horizontal.parameters = {
source: {
code: `
<div style="'display: grid; grid-template-columns: 1fr auto;">
<uui-button-inline-create label="Create Item"></uui-button-inline-create>
<div style="padding: 10px;">Item 1</div>
<uui-button-inline-create label="Create Item"></uui-button-inline-create>
<div style="padding: 10px;">Item 2</div>
Expand All @@ -135,3 +156,41 @@ Horizontal.parameters = {
},
},
};

export const Href: Story = () =>
html` <h3>Using HREF</h3>
<div id="container" style="max-width: 500px; border: 1px solid grey">
<uui-button-inline-create
href="#0"
label="Create Item"></uui-button-inline-create>
<div style="padding: 10px;">Item 1</div>
<uui-button-inline-create
href="#1"
label="Create Item"></uui-button-inline-create>
<div style="padding: 10px;">Item 2</div>
<uui-button-inline-create
href="#2"
label="Create Item"></uui-button-inline-create>
<div style="padding: 10px;">Item 3</div>
<uui-button-inline-create
href="#3"
label="Create Item"></uui-button-inline-create>
</div>`;
AAAOverview.storyName = 'Overview';
AAAOverview.parameters = {
docs: {
source: {
code: `
<div>
<uui-button-inline-create href="#0" label="Create Item"></uui-button-inline-create>
<div style="padding: 10px;">Item 1</div>
<uui-button-inline-create href="#1" label="Create Item"></uui-button-inline-create>
<div style="padding: 10px;">Item 2</div>
<uui-button-inline-create href="#2" label="Create Item"></uui-button-inline-create>
<div style="padding: 10px;">Item 3</div>
<uui-button-inline-create href="#3" label="Create Item"></uui-button-inline-create>
</div>
`,
},
},
};
Loading