Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline-button-create: Add href #720

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Inline-button-create: Add href #720

merged 5 commits into from
Jan 23, 2024

Conversation

JesmoDev
Copy link
Contributor

Adds href and target properties to inline button create
Also fixes the placement of the button so it is no longer offset to the side.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@iOvergaard iOvergaard added the enhancement New feature or request label Jan 23, 2024
@iOvergaard
Copy link
Contributor

See my comment on ref-node also: #715 (comment)

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-720.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-720.westeurope.azurestaticapps.net

nielslyngsoe
nielslyngsoe approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) January 23, 2024 15:35
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-720.westeurope.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-720.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe merged commit 7d8affd into v1/contrib Jan 23, 2024
9 of 10 checks passed
@nielslyngsoe nielslyngsoe deleted the feature/inline-button-create-href branch January 23, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard left review comments

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JesmoDev @iOvergaard @nielslyngsoe