Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: uui-ref-node should have href and target properties #715

Merged
merged 3 commits into from
Jan 23, 2024
Merged

feat: uui-ref-node should have href and target properties #715

merged 3 commits into from
Jan 23, 2024

Conversation

JesmoDev
Copy link
Contributor

Adds href and target to ref-node
Also fixes import issues in ref node

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@iOvergaard iOvergaard added the enhancement New feature or request label Jan 23, 2024
@iOvergaard iOvergaard mentioned this pull request Jan 23, 2024
Merged
7 tasks
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-715.westeurope.azurestaticapps.net

@iOvergaard iOvergaard mentioned this pull request Jan 23, 2024
Closed
@iOvergaard iOvergaard changed the title ref-node: Add href and target properties feat: uui-ref-node should have href and target properties Jan 23, 2024
@iOvergaard iOvergaard merged commit 12feafb into v1/contrib Jan 23, 2024
9 of 10 checks passed
@iOvergaard iOvergaard deleted the feature/ref-node-href branch January 23, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe left review comments

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JesmoDev @iOvergaard @nielslyngsoe