Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uui-tab-group does not support having a gap between tabs #712

Merged
merged 15 commits into from
Jan 23, 2024
Merged

uui-tab-group does not support having a gap between tabs #712

merged 15 commits into from
Jan 23, 2024

Conversation

JesmoDev
Copy link
Contributor

@JesmoDev JesmoDev commented Jan 22, 2024 •
edited
Loading

Adds CSS variable to add gaps between tab items.
--uui-tab-group-gap

Only pixel values are valid. Any other value will be converted to pixels if possible. Invalid number values will fallback to 0
Examples 20em => 20px 25% => 25px 10 => 10px 100whatever => 100px sdh10 => NaN => 0px

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@JesmoDev JesmoDev requested a review from iOvergaard January 22, 2024 09:47
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-712.westeurope.azurestaticapps.net

@JesmoDev JesmoDev linked an issue Jan 22, 2024 that may be closed by this pull request
Tab group does not support gap property. #707
Closed
@JesmoDev JesmoDev mentioned this pull request Jan 22, 2024
Closed
7 tasks
@iOvergaard
Copy link
Contributor

What is it we are trying to achieve here using a CSS variable rather than an element property?

@nielslyngsoe nielslyngsoe changed the base branch from release/1.6.0 to v1/contrib January 23, 2024 09:58
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-712.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-712.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-712.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the enhancement New feature or request label Jan 23, 2024
@iOvergaard iOvergaard changed the title Feature/tab group gap uui-tab-group does not support having a gap between tabs Jan 23, 2024
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-712.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) January 23, 2024 14:41
@nielslyngsoe nielslyngsoe requested review from nielslyngsoe and removed request for iOvergaard January 23, 2024 14:41
nielslyngsoe
nielslyngsoe approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well :-)

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-712.westeurope.azurestaticapps.net

2 similar comments
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-712.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-712.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe merged commit 2f07793 into v1/contrib Jan 23, 2024
9 of 10 checks passed
@nielslyngsoe nielslyngsoe deleted the feature/tab-group-gap branch January 23, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tab group does not support gap property.
4 participants
@JesmoDev @iOvergaard @nielslyngsoe @julczka