Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab group does not support gap property. #707

Closed
julczka opened this issue Jan 17, 2024 · 0 comments · Fixed by #712
Closed

Tab group does not support gap property. #707

julczka opened this issue Jan 17, 2024 · 0 comments · Fixed by #712
Assignees
@JesmoDev
Labels
bug Something isn't working needs triage This issue has not been tested by a team member yet

Comments

@julczka
Copy link
Contributor

julczka commented Jan 17, 2024 •
edited
Loading

Which exact UI Library version are you using? For example: 1.0.1 - don't just write v1.

1.6.0-rc-3

Bug summary

uui-tab group does not support gap property on it.
The #calculateBreakpoints method, responsible for setting the width on uui-tab-group, takes to account only widths of each uui-tab element, but not their margings or a gap property set on the uui-tab-group

Specifics

On the image below you can see a use case from cloud portal, where the layout of tabs is broken due to width set on the tab group
image

Steps to reproduce

follow the story added in PR #708

Expected result / actual result

It is possible to use tabs with a gap property on uui-tab-group
@julczka julczka added bug Something isn't working needs triage This issue has not been tested by a team member yet labels Jan 17, 2024
@julczka julczka mentioned this issue Jan 17, 2024
Closed
7 tasks
@JesmoDev JesmoDev linked a pull request Jan 22, 2024 that will close this issue
uui-tab-group does not support having a gap between tabs #712
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JesmoDev JesmoDev

Labels
bug Something isn't working needs triage This issue has not been tested by a team member yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

uui-tab-group does not support having a gap between tabs umbraco/Umbraco.UI
2 participants
@JesmoDev @julczka