Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uui-popover-container: disable the focusout close listener #663

Merged
merged 3 commits into from
Nov 22, 2023
Merged

uui-popover-container: disable the focusout close listener #663

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf5971c
disable close on focus
JesmoDev Nov 21, 2023
c6c44a4
Merge remote-tracking branch 'origin/v1/contrib' into bugfix/popover-…
JesmoDev Nov 21, 2023
0f3746c
remove focus eventlistener
JesmoDev Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions packages/uui-popover-container/lib/uui-popover-container.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ export class UUIPopoverContainerElement extends LitElement {
!HTMLElement.prototype.hasOwnProperty('popover') && polyfill.bind(this)();

super.connectedCallback();

this.addEventListener('focusout', this.#onFocusOut);
this.addEventListener('beforetoggle', this.#onBeforeToggle);
}

Expand All @@ -85,15 +83,6 @@ export class UUIPopoverContainerElement extends LitElement {
this.removeEventListener('beforetoggle', this.#onBeforeToggle);
}

#onFocusOut = (event: FocusEvent) => {
// If focus is outside of the container, then the popover will close.
if (!event.relatedTarget || !this.contains(event.relatedTarget as Node)) {
// @ts-ignore - This is part of the new popover API, but typescript doesn't recognize it yet.
this.hidePopover();
this._open = false;
}
};

#onBeforeToggle = (event: any) => {
this._open = event.newState === 'open';

Expand Down
Loading