Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uui-popover-container: disable the focusout close listener #663

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

JesmoDev
Copy link
Contributor

Disables the closing the popover when focusing outside, as it is buggy and sometimes closes the popover even when clicking inside it.

Close on focus outside was used for usecases such as tab navigation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@JesmoDev JesmoDev enabled auto-merge November 21, 2023 03:09
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-663.westeurope.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-663.westeurope.azurestaticapps.net

@iOvergaard iOvergaard changed the title Bugfix/popover container disable focus close uui-popover-container: disable the focusout close listener Nov 22, 2023
@iOvergaard iOvergaard added the bug Something isn't working label Nov 22, 2023
@iOvergaard iOvergaard disabled auto-merge November 22, 2023 08:09
@iOvergaard iOvergaard merged commit 23900eb into v1/contrib Nov 22, 2023
9 of 10 checks passed
@iOvergaard iOvergaard deleted the bugfix/popover-container-disable-focus-close branch November 22, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants