Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend detail page summary #1661

Merged
merged 26 commits into from
Aug 14, 2024
Merged

Extend detail page summary #1661

merged 26 commits into from
Aug 14, 2024

Conversation

mietcls
Copy link
Member

@mietcls mietcls commented Jul 16, 2024

Depends on #1659 – needs to merged first.

  1. Made detail page summary in header more informative
    Fixes [quick import] Make publication detail header more informative #1338

🙏 Not happened yet: live updating of header after editing. Could use some help with that, can be in a separate PR.

  • publication: citation style header with
    • authors or editors
    • title
    • Journal title
    • year
    • page count / volume / issue / first and last page
    • publisher
    • conference name if applicable
  • datasetscitation style header with
    • contributors
    • title
    • publisher
    • year
    • identifier type
  • Biblio ID
  • Repositioning of header elements and responsiveness
  1. Aligned access level icons and copy in search overview and full text & files view
    Task part of Biblio issues after June release  #1623

TODO:

  • dataset DOI double check
  • double check names for different publication types

@mietcls mietcls marked this pull request as ready for review July 31, 2024 08:58
@mietcls mietcls changed the title Experiment/reshuffle detail page summary Extend detail page summary Aug 1, 2024
views/publication/show.templ Outdated Show resolved Hide resolved
views/publication/show.templ Outdated Show resolved Hide resolved
views/publication/show.templ Outdated Show resolved Hide resolved
views/publication/show.templ Outdated Show resolved Hide resolved
Copy link
Contributor

@verheyenkoen verheyenkoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 tests fail because of these changes (issue-1370).

@mietcls
Copy link
Member Author

mietcls commented Aug 7, 2024

2 tests fail because of these changes (issue-1370).

This one will change as well when the info sidebar is there, to save space and only focus on the important info: #1663
We would only show edited in the header, and the other info would move into the info sidebar.

@mietcls
Copy link
Member Author

mietcls commented Aug 8, 2024

@verheyenkoen fixed with 6abd3e9

# Conflicts:
#	cypress/e2e/issues/issue-1370.cy.ts
@nics nics merged commit 572eb07 into dev Aug 14, 2024
@nics nics deleted the experiment/reshuffle-detail-page-summary branch August 14, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[quick import] Make publication detail header more informative
3 participants