Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ublksrv: Add kernel version and g++ options check #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ublksrv: Add kernel version and g++ options check #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,35 @@ AC_CONFIG_FILES([Makefile
tests/Makefile
ublksrv.pc])

#
# Check if g++ supports -fcoroutines -std=c++20
#
AC_LANG_PUSH([C++])
CXXFLAGS_save=$CXXFLAGS
CXXFLAGS="$CXXFLAGS -fcoroutines -std=c++20"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not add it in this way, and libublksrv doesn't need c++20 coroutine, and only the target code requires it.

T001_PROGRAM="
#include <coroutine>
int main(void) {
return 0;
}
"
AC_MSG_CHECKING([whether $CXX supports -fcoroutines -std=c++20])
AC_COMPILE_IFELSE(
[AC_LANG_SOURCE([$T001_PROGRAM])],
[AC_MSG_RESULT([yes])],
[AC_MSG_FAILURE([no])]
)

CXXFLAGS=$CXXFLAGS_save
AC_LANG_POP([C++])

#
# Only support kernel 5.19 and beyond
#
linux_kernel_ver=$(uname -r)
AX_COMPARE_VERSION($linux_kernel_ver, [ge], [5.19],
[AC_MSG_NOTICE([checking for kernel version >= 5.19.X. Found... $linux_kernel_ver])],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimum kernel version should be v6.0 which isn't released yet, ublk driver is merged to v6.0, and io_uring passthrough command is merged to v5.19.

[AC_MSG_ERROR([Expected Kernel Version >= 5.19.X. Found... $linux_kernel_ver]),[1]])


AC_OUTPUT