Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ublksrv: Add kernel version and g++ options check #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harshad1024
Copy link

This patch updates configure.ac to add
kernel version checks and g++ checks
mandatory. This is because if the criteria
is not met the build will fail during actual
make.

This make minimum kernel version as 5.19.X.
Anything lesser than 5.19 the build will stop
with failure.

This patch also confirms if g++/c++ supports
CFLAGS option of "-fcoroutines -std=c++20".
If not supported the build stops with failure.

Signed-off-by: H Arshad [email protected]

This patch updates configure.ac to add
kernel version checks and g++ checks
mandatory. This is because if the criteria
is not met the build will fail during actual
make.

This make minimum kernel version as 5.19.X.
Anything lesser than 5.19 the build will stop
with failure.

This patch also confirms if g++/c++ supports
CFLAGS option of "-fcoroutines -std=c++20".
If not supported the build stops with failure.

Signed-off-by: H Arshad <[email protected]>
#
AC_LANG_PUSH([C++])
CXXFLAGS_save=$CXXFLAGS
CXXFLAGS="$CXXFLAGS -fcoroutines -std=c++20"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not add it in this way, and libublksrv doesn't need c++20 coroutine, and only the target code requires it.

#
linux_kernel_ver=$(uname -r)
AX_COMPARE_VERSION($linux_kernel_ver, [ge], [5.19],
[AC_MSG_NOTICE([checking for kernel version >= 5.19.X. Found... $linux_kernel_ver])],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimum kernel version should be v6.0 which isn't released yet, ublk driver is merged to v6.0, and io_uring passthrough command is merged to v5.19.

@ming1 ming1 force-pushed the master branch 2 times, most recently from 061a794 to c7170a8 Compare December 13, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants