Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: vertically stacked permits" #296

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

0x4007
Copy link
Member

@0x4007 0x4007 commented Sep 9, 2024

Reverts #274

image

Styles are still messed up. It's not centered. These details need to be addressed.

@0x4007 0x4007 requested a review from Keyrxng as a code owner September 9, 2024 13:01
@0x4007 0x4007 merged commit ca0f4bd into development Sep 9, 2024
5 of 6 checks passed
@0x4007 0x4007 deleted the revert-274-rewrite-transactions branch September 9, 2024 13:02
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Sep 9, 2024

Copy link
Contributor

github-actions bot commented Sep 9, 2024

@0x4007
Copy link
Member Author

0x4007 commented Sep 9, 2024

@pbkompasz as a heads up this isn't accepted.

Strike one for the auto merger.

@pbkompasz
Copy link
Contributor

@0x4007 Should I open a separate PR with the fixed allignment? Also did you find any other issues, or something else that is not correct? Let me know and I will fix those, and sorry for the delayed response. I was AFK for the past couple of days.

@0x4007
Copy link
Member Author

0x4007 commented Sep 12, 2024

I only recall style problems.

@pbkompasz
Copy link
Contributor

@0x4007 This is for a single permit? I cannot reproduce it.
a5a98676-cae6-4225-bf5b-bde6efeed8f5

@pbkompasz pbkompasz mentioned this pull request Sep 20, 2024
@0x4007
Copy link
Member Author

0x4007 commented Sep 22, 2024

@Keyrxng can you see why continuous deployment isn't working? I need to test the latest commits.

1 similar comment
@0x4007
Copy link
Member Author

0x4007 commented Sep 22, 2024

@Keyrxng can you see why continuous deployment isn't working? I need to test the latest commits.

@Keyrxng
Copy link
Member

Keyrxng commented Sep 22, 2024

https://github.com/ubiquity/pay.ubq.fi/actions/runs/10836083321

It seems to have "broken" from this b32868b commit which was around the time of the multiple reverts and it was working consistently before this. It fired off one successful workflow during this commit' lifetime and fired off two unsuccessful ones coming from @rndquu' account as opposed to yours.

Now it seems that it's only working whenever a core team member pushes and is not working for any normal contributor... deploy to cloudflare happens after a successful build action run and it appears like contributor' can complete those action runs.

The logic between either workflow hasn't changed, looking at the error logs it's definitely env related at least setting something in the env, I'll assume it's the deployment URL but idk because I'm not good with bash (I'd convert every bash script we have into TS if I could click my fingers) and I haven't worked on that aspect of CI really.

I'm not sure how I'd begin to debug it either but I am too tired now to give it the attention it needs. Rn now I'm assuming it only wants to deploy to development because of a URL issue but what caused it rn I'm not sure.

@0x4007
Copy link
Member Author

0x4007 commented Sep 22, 2024

Maybe @rndquu has a better idea then

@rndquu
Copy link
Member

rndquu commented Oct 9, 2024

As far as I understand right now cloudflare previews work fine both for core developers and contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants