-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat: vertically stacked permits" #296
Conversation
|
@pbkompasz as a heads up this isn't accepted. Strike one for the auto merger. |
@0x4007 Should I open a separate PR with the fixed allignment? Also did you find any other issues, or something else that is not correct? Let me know and I will fix those, and sorry for the delayed response. I was AFK for the past couple of days. |
I only recall style problems. |
@0x4007 This is for a single permit? I cannot reproduce it. |
@Keyrxng can you see why continuous deployment isn't working? I need to test the latest commits. |
1 similar comment
@Keyrxng can you see why continuous deployment isn't working? I need to test the latest commits. |
https://github.com/ubiquity/pay.ubq.fi/actions/runs/10836083321 It seems to have "broken" from this b32868b commit which was around the time of the multiple reverts and it was working consistently before this. It fired off one successful workflow during this commit' lifetime and fired off two unsuccessful ones coming from @rndquu' account as opposed to yours. Now it seems that it's only working whenever a core team member pushes and is not working for any normal contributor... deploy to cloudflare happens after a successful The logic between either workflow hasn't changed, looking at the error logs it's definitely env related at least setting something in the env, I'll assume it's the deployment URL but idk because I'm not good with bash (I'd convert every bash script we have into TS if I could click my fingers) and I haven't worked on that aspect of CI really. I'm not sure how I'd begin to debug it either but I am too tired now to give it the attention it needs. Rn now I'm assuming it only wants to deploy to development because of a URL issue but what caused it rn I'm not sure. |
Maybe @rndquu has a better idea then |
As far as I understand right now cloudflare previews work fine both for core developers and contributors |
Reverts #274
Styles are still messed up. It's not centered. These details need to be addressed.