Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo Carousel #196

Closed
0x4007 opened this issue Mar 11, 2024 · 44 comments · Fixed by #274
Closed

Redo Carousel #196

0x4007 opened this issue Mar 11, 2024 · 44 comments · Fixed by #274

Comments

@0x4007
Copy link
Member

0x4007 commented Mar 11, 2024

I think the aesthetics are not good with the carousel.

localhost_8080__claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIwIn0sIm5vbmNlIjoiNzk2NDgxODQwMDA5MzQ0ODI4NzA0NjE0NjAzMDE2NDE5NzU4NTM0Nz

Instead we should render all the permits vertically stacked all at once. Something like the following:

localhost_8080__claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIwIn0sIm5vbmNlIjoiNzk2NDgxODQwMDA5MzQ0ODI4NzA0NjE0NjAzMDE2NDE5NzU4NT (1)

I suspect that we will need to redo quite a bit of logic, as the app seems to be designed only to render one at a time.

@devpanther
Copy link
Contributor

/start

Copy link

ubiquibot bot commented Mar 11, 2024

DeadlineTue, Mar 12, 5:40 PM UTC
Registered Wallet 0xf76F1ACB66020f893c95371f740549F312DEA3f1
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@el-buku
Copy link

el-buku commented Mar 21, 2024

Still available?

@devpanther
Copy link
Contributor

No, on it

@0x4007
Copy link
Member Author

0x4007 commented Mar 21, 2024

No, on it

You should have at least a draft pull open to retain this task

@devpanther
Copy link
Contributor

No, on it

You should have at least a draft pull open to retain this task

I will get one open soon, too many files to change.. wasn't a 1 day task as a lot would easily break

Copy link

ubiquibot bot commented Mar 25, 2024

# No linked pull requests to close

@jordan-ae
Copy link
Contributor

jordan-ae commented Mar 26, 2024

@pavlovcik Since the list might get quite long isn't it necessary to implement some form of pagination here? Probably after 10 permits, we should break to the next page. It will improve the UX significantly in my opinion.

@0x4007
Copy link
Member Author

0x4007 commented Mar 27, 2024

Makes sense but I think in the near term let's not worry about that. The only planned behavior for multi permit payouts is something like 1. Stablecoin 2. Governance token reward 3. NFT POAP reward.

So the most I expect to support is three for our near term vision.

@jordan-ae
Copy link
Contributor

/start

Copy link

ubiquibot bot commented Mar 27, 2024

DeadlineThu, Mar 28, 12:58 PM UTC
Registered Wallet 0x2F05fD58023B0a95d1866aa0A3b672cEf05945c5
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@jordan-ae
Copy link
Contributor

@pavlovcik and @rndquu,

I'm currently working on setting up a repository, and I've been following the instructions provided in the README. Although I managed to start the application, I'm encountering an issue where it continuously loads without rendering any actual data.

Could you please offer some guidance on troubleshooting steps to get the application working as intended? Any insights or suggestions would be greatly appreciated. Thank you!

@rndquu
Copy link
Member

rndquu commented Mar 28, 2024

@pavlovcik and @rndquu,

I'm currently working on setting up a repository, and I've been following the instructions provided in the README. Although I managed to start the application, I'm encountering an issue where it continuously loads without rendering any actual data.

Could you please offer some guidance on troubleshooting steps to get the application working as intended? Any insights or suggestions would be greatly appreciated. Thank you!

In order for any data to be displayed the claim URL query parameter should be provided which contains all of the data (example).

You may generate test claim URLs with this script. If the app is still loading continuously the issue is somewhere else.

@jordan-ae
Copy link
Contributor

@rndquu I'm using the ERC721 url generated in the terminal. I'm getting a CORS error in the console.

Screenshot 2024-03-29 at 01 12 32

@0x4007
Copy link
Member Author

0x4007 commented Mar 29, 2024

Try now #213

Be sure to pull

@jordan-ae
Copy link
Contributor

Try now #213

Be sure to pull

Works now Thanks

Copy link

ubiquibot bot commented Jun 4, 2024

# These linked pull requests are closed:  <a href="https://github.com/ubiquity/pay.ubq.fi/pull/216">#216</a> 

@Sadaf-A
Copy link

Sadaf-A commented Jul 5, 2024

/start

Copy link

ubiquibot bot commented Jul 5, 2024

Warning! This task was created over 116 days ago. Please confirm that this issue specification is accurate before starting.
DeadlineSat, Jul 6, 9:13 PM UTC
Registered Wallet 0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

ubiquibot bot commented Aug 1, 2024

Warning! This task was created over 143 days ago. Please confirm that this issue specification is accurate before starting.
DeadlineFri, Aug 2, 5:04 PM UTC
Registered Wallet 0x26BfbD8ED2B302ec2c2B6f063C4caF7abcB062e0
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@ubiquity-os ubiquity-os bot closed this as completed in #274 Sep 9, 2024
@0x4007 0x4007 reopened this Sep 9, 2024
@0x4007 0x4007 closed this as completed Sep 9, 2024
@0x4007 0x4007 reopened this Sep 9, 2024
@ubiquity ubiquity deleted a comment from ubiquity-os bot Sep 9, 2024
Copy link
Contributor

ubiquity-os bot commented Sep 13, 2024

@pbkompasz, this task has been idle for a while. Please provide an update.

Copy link
Contributor

ubiquity-os bot commented Sep 16, 2024

@pbkompasz, this task has been idle for a while. Please provide an update.

1 similar comment
Copy link
Contributor

ubiquity-os bot commented Sep 20, 2024

@pbkompasz, this task has been idle for a while. Please provide an update.

@pbkompasz
Copy link
Contributor

@0x4007 What is the status on this issue? I tested the build on multiple devices but did not run into the style issues mentioned here.

@0x4007
Copy link
Member Author

0x4007 commented Sep 20, 2024

It looks like there haven't been any changes. Best if there are fixes made and if our continuous deployments work I can test from mobile to approve

@rndquu
Copy link
Member

rndquu commented Sep 20, 2024

As far as I understand this PR should be reopened against the latest development branch so that we could QA it again.

@pbkompasz
Copy link
Contributor

@0x4007 Okay but what are the issues? I couldn't reproduce the alignment one mentioned here.
See here

Copy link
Contributor

ubiquity-os bot commented Sep 24, 2024

@pbkompasz, this task has been idle for a while. Please provide an update.

@0x4007
Copy link
Member Author

0x4007 commented Sep 24, 2024

You can reopen your pull like what rndquu said and we can proceed

@zugdev
Copy link
Contributor

zugdev commented Oct 21, 2024

Is this still valid considering the mint card functionality?

@Keyrxng
Copy link
Member

Keyrxng commented Oct 21, 2024

Is this still valid considering the mint card functionality?

I raised this same point during review of beta branch, it's cluttered right now but cards are being moved into their own UI and if so then this is still relevant yeah.

Copy link
Contributor

ubiquity-os bot commented Oct 22, 2024

@pbkompasz the deadline is at Wed, Oct 23, 7:23 AM UTC

@0x4007 0x4007 closed this as completed Oct 22, 2024
Copy link
Contributor

ubiquity-os bot commented Oct 22, 2024

! Failed to run comment evaluation. SyntaxError: Unterminated string in JSON at position 35

1 similar comment
Copy link
Contributor

ubiquity-os bot commented Oct 22, 2024

! Failed to run comment evaluation. SyntaxError: Unterminated string in JSON at position 35

@0x4007
Copy link
Member Author

0x4007 commented Oct 22, 2024

@gentlementlegen there is a parser error and I think it would make sense to include the sourcemap because debugging from a compiled js file obviously is not the best.

@gentlementlegen
Copy link
Member

gentlementlegen commented Oct 22, 2024

@0x4007 Actually the logs are pretty explicit. This happens when OpenAI doesn't return a properly formatted JSON, see this line.
Usually fixes itself on rerun.

@0x4007
Copy link
Member Author

0x4007 commented Oct 22, 2024

dist/index.js:291:6136492 is not more clear than pointing to the typescript source code.

@gentlementlegen
Copy link
Member

It also says async ContentEvaluatorModule._evaluateComments which only misses the specific line. I can commit the source map but it will likely slow down the process, we have to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment