Improvements

[Keyrxng]

Resolves #19

Changes:

• readme display
• production config only
• reset to defaults

QA:

readme-with-improvements.mp4

[Keyrxng]

This PR became quite long so I will address tests in another task

@rndquu @gentlementlegen if you'd like to take a look when you can, cheers.

[gentlementlegen]

Seems to work fine although I have a few remarks:

• I don't seem to have padding like in your video

• the left panel shifts a bit when hovering the "use default" button
• I am only seeing two orgs but I am in more orgs that that, how are they chosen?
• going back from the edit plugin menu makes the bar take the full width

- the "remove" button should maybe be disabled on plugins that are not installed

[Keyrxng]

I am only seeing two orgs but I am in more orgs that that, how are they chosen?

https://docs.github.com/en/rest/orgs/orgs?apiVersion=2022-11-28#list-organizations-for-the-authenticated-user

public async getGitHubUserOrgs(): Promise<string[]> {
    const octokit = await this.getOctokit();
    const response = await octokit.rest.orgs.listForAuthenticatedUser();
    return response.data.map((org: { login: string }) => org.login);
  }

What orgs did you see?

I've considered other methods but the question is: What orgs do you want to see?

• Orgs that you are an admin of or just owner of, collaborator of?
• Should the partner determine which roles can edit the config or do we enforce rules, if we enforce then what should they be?

I think a task should be created and it discussed there because it'll involve additional work and direction.

We sort of scrapped global config variables from ubiquity-os-config.yml but we could leverage that to enforce partner defined roles which can edit (at least via the UI).

E.g: The org owner must use it after kernel-setup and we allow them to input roles that can edit and we write this to the config separate from plugins: and we read this on fetch and check against our authenticated user.

[Keyrxng]

the left panel shifts a bit when hovering the "use default" button

I couldn't reproduce this pls lmk if it happens again and what you suggest as a fix/steps to repro, cheers

[zugdev]

We should only show "no orgs available" after we've looked at the request answer, it can be confusing in high latency environments. Show "loading", either as string or animation. Perhaps copy from work.ubq.fi.

[zugdev]

1. Though I've selected an org there is no visual indicator of what org I am at, this can be confusing.

2. README fails to be opened for me. Also, no console.error log to help debug this.

[Keyrxng]

README fails to be opened for me. Also, no console.error log to help debug this.

Any chance you wrote a log to find out as I cannot repro and I don't think it happened for mentlegen either or he'd have mentioned it?

I can add a console.error but would like to know the root cause as me adding a log won't resolve it, appreciate if you could.

We should only show "no orgs available"

I thought this notification was enough but I have updated the title for while it's fetching also

[zugdev]

These icons are not intuitive, perhaps text is better.

[Keyrxng]

@Keyrxng Check this screenshot:

The "Assistive pricing" plugin is disabled although its config is present in the .ubiquity-os.config.yml file. The expected behavior for the "Assistive pricing" is to be in the enabled mode.

Pls fix

My apologies @rndquu, fixed now

[rndquu]

@Keyrxng

1. For some of the plugins (User activity watcher, Automated merging, Telegram kernel) getting the No plugin URL found for user-activity-watcher error:

As far as I understand those plugins work as github actions so it's not clear why we can't set them up.

2. The command-ask plugin shows empty UI:

Pls fix

[Keyrxng]

Sorted @rndquu

1. PRs opened in relevant repos: related to manifest.name mismatch #27
2. I'm not able to reproduce this. Was it from a fresh cache fetch or did you have it installed?
   

[Keyrxng]

I merged ubiquity-os-marketplace/ubiquity-os-kernel-telegram#40 and kernel telegram is now working so the other PRs need merged and we should be good to merge this?

1. Technically kernel-telegram is not built to support being installed by partners at the moment so should probs not be displayed.
2. It has two config entries: A) I detect url(s), if plural, create an entry for each B) See links below

• Add url property to manifest.json plugin-template#33 (comment)
• Self dispatched workflow functions ubiquity-os-marketplace/ubiquity-os-kernel-telegram#20

[rndquu]

Check this screenshot:

Although the registerWalletWithVerification is set to true in the yml config the option in the html UI is not check while the expected behavior is to load current config values.

Pls fix.

[rndquu]

Sorted @rndquu

1. PRs opened in relevant repos: related to manifest.name mismatch #27
2. I'm not able to reproduce this. Was it from a fresh cache fetch or did you have it installed?
   

1. So, as far as I understand, when Add parameter descriptions for core plugins in the plugin-input.ts #24 is solved all plugins setup will be fine because of the correct name property.
2. I cleared the cache and error is gone

[Keyrxng]

Fixed, I had forgot to set checked relevant to the input value.

So, as far as I understand, when #24 is solved all plugins setup will be fine because of the correct name property.
I cleared the cache and error is gone

Yeah as can be seen with kernel-telegram after I merged. Excellent re: cache issue, I tried to improve the fetching of the readme because some would 404 maybe the manifest fetching needs made more robust if we see anything like that again

[rndquu]

Appears like you have solved the problems I found. The only thing I managed to find now is the overlap between table and header:

We could create a issue later for me to fix these kind of CSS problems. By taking a very quick look:

1. Nav should be inside of header
2. The height for content does not need to be calculated just use display block use the available height
3. Fix overlapping
4. Make responsive

I suppose when all of the critical issues are ready (#24, #22, #20) we can get back to neaten up the css.

[rndquu]

@Keyrxng Now you could merge the latest main branch into your other PRs from https://github.com/ubiquity-os/ubiquity-os-plugin-installer/pulls