Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #19

Closed
rndquu opened this issue Nov 15, 2024 · 15 comments · Fixed by #25
Closed

UI improvements #19

rndquu opened this issue Nov 15, 2024 · 15 comments · Fixed by #25

Comments

@rndquu
Copy link
Member

rndquu commented Nov 15, 2024

Depends on #13

What should be done:

  1. The "select configuration" step should be removed. Always use the "production" config.
  2. Show plugin readme on installing a new plugin (original comment)
  3. Show indicator if plugin is already installed (original comment)
  4. Load current config values in the editor (if config is present)
  5. Add "Reset to defaults" button which resets plugin options to default values (original comment)
  6. Add github redirect to the same page (example)
@zugdev
Copy link

zugdev commented Nov 15, 2024

I'll take this one as soon as #13 is through.

@Keyrxng
Copy link
Contributor

Keyrxng commented Nov 15, 2024

I'll take this one as soon as #13 is through.

It's all good brother I got things under control here, I'm happy to carry on and clear the new tasks prior to merge. I assume you'll be reviewing my PRs which will take up some time and I assume you have more pressing tasks to address anyway like permit rollups etc

@Keyrxng
Copy link
Contributor

Keyrxng commented Nov 21, 2024

The "select configuration" step should be removed. Always use the "production" config.

@rndquu Is this certain? Are we deprecating the dev bot instance or is this just in terms of partners? i.e including a less visible method of selecting the dev config for internal use? I figured this would be used for development too as @gentlementlegen had mentioned building something similar for his own use

@rndquu
Copy link
Member Author

rndquu commented Nov 21, 2024

@rndquu Is this certain? Are we deprecating the dev bot instance or is this just in terms of partners?

Yes, https://github.com/ubiquity-os/ubiquity-os-plugin-installer is for partners. Development config can be created manually at any time.

@rndquu
Copy link
Member Author

rndquu commented Nov 21, 2024

@Keyrxng Notice a new subtask:

6. Add github redirect to the same page ([example](https://github.com/ubiquity/work.ubq.fi/blob/5ad2731d99f3c03cdb52fe5f7122e412669ca0bd/src/home/rendering/render-github-login-button.ts#L37))

@Keyrxng
Copy link
Contributor

Keyrxng commented Nov 21, 2024

/start

@Keyrxng Keyrxng mentioned this issue Nov 21, 2024
Keyrxng pushed a commit to ubq-testing/ubiquity-os-plugin-installer that referenced this issue Nov 26, 2024
* feat: default Jest testing configuration

* Update .github/workflows/jest-testing.yml

* chore: moved jest config from js to ts

* chore: removed unused check to trigger Jest Action

---------

Co-authored-by: アレクサンダー.eth <[email protected]>
@rndquu rndquu reopened this Nov 28, 2024
@rndquu rndquu closed this as completed Nov 28, 2024
@rndquu rndquu reopened this Nov 28, 2024
@rndquu rndquu closed this as completed Nov 28, 2024
@rndquu
Copy link
Member Author

rndquu commented Nov 28, 2024

The bot is not responding because of ubiquity-os/ubiquity-os-kernel#195. I'll try to regenerate later.

@rndquu rndquu removed this from Development Nov 29, 2024
@rndquu rndquu reopened this Nov 29, 2024
@rndquu rndquu closed this as completed Nov 29, 2024
@rndquu rndquu reopened this Nov 29, 2024
@rndquu rndquu closed this as completed Nov 29, 2024
@rndquu rndquu reopened this Nov 29, 2024
@rndquu rndquu closed this as completed Nov 29, 2024
@rndquu rndquu reopened this Nov 29, 2024
@rndquu rndquu closed this as completed Nov 29, 2024
Copy link

+ Evaluating results. Please wait...

Copy link

 [ 302.88075 WXDAI ] 

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueTask1300
IssueComment22.88075
ReviewComment210
Conversation Incentives
CommentFormattingRelevancePriorityReward
It's all good brother I got things under control here, I'm happy…
2.97
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 54
  wordValue: 0.1
  result: 2.97
0.531.10625
@rndquu Is this certain? Are we deprecating the dev bot instance…
2.97
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 54
  wordValue: 0.1
  result: 2.97
0.831.7745
Resolves #19Changes:- readme display- production config on…
6.5
content:
  content:
    p:
      score: 0
      elementCount: 7
    ul:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 3
    a:
      score: 5
      elementCount: 1
  result: 6.5
regex:
  wordCount: 12
  wordValue: 0
  result: 0
0.830
Move them to where? I lack the imagination lmao. Perhaps the lit…
5
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 36
  wordValue: 0
  result: 0
0.730
This PR became quite long so I will address tests in another tas…
0
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 27
  wordValue: 0
  result: 0
0.630
https://docs.github.com/en/rest/orgs/orgs?apiVersion=2022-11-28#…
6
content:
  content:
    p:
      score: 0
      elementCount: 8
    ul:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
    a:
      score: 5
      elementCount: 1
  result: 6
regex:
  wordCount: 142
  wordValue: 0
  result: 0
0.530
I couldn't reproduce this pls lmk if it happens again and what y…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 22
  wordValue: 0
  result: 0
0.430
Any chance you wrote a log to find out as I cannot repro and I d…
5
content:
  content:
    p:
      score: 0
      elementCount: 4
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 74
  wordValue: 0
  result: 0
0.330
They do have text when hovered and were part of 0x4007's origina…
5
content:
  content:
    p:
      score: 0
      elementCount: 2
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 40
  wordValue: 0
  result: 0
0.630
1. That is relevant to https://github.com/ubiquity-os/ubiquity-o…
11
content:
  content:
    ol:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
    p:
      score: 0
      elementCount: 5
    a:
      score: 5
      elementCount: 2
  result: 11
regex:
  wordCount: 126
  wordValue: 0
  result: 0
0.530
Resolved here [7bd56ac](https://github.com/ubiquity-os/ubiquity-…
5
content:
  content:
    p:
      score: 0
      elementCount: 3
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 54
  wordValue: 0
  result: 0
0.730
waiting for the team
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 4
  wordValue: 0
  result: 0
0.230
![image](https://github.com/user-attachments/assets/ade27502-3b4…
11
content:
  content:
    p:
      score: 0
      elementCount: 7
    img:
      score: 5
      elementCount: 2
    ul:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
    hr:
      score: 0
      elementCount: 1
  result: 11
regex:
  wordCount: 99
  wordValue: 0
  result: 0
0.530
So this UI should display all orgs that the user is an admin of …
0
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 50
  wordValue: 0
  result: 0
0.630
Both of those plugins fixed: `pricing` was improperly se…
10
content:
  content:
    p:
      score: 0
      elementCount: 7
    img:
      score: 5
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 10
regex:
  wordCount: 81
  wordValue: 0
  result: 0
0.730
`rest.orgs.listForUser():`This returns all 4 orgs for …
0
content:
  content:
    p:
      score: 0
      elementCount: 5
    em:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 93
  wordValue: 0
  result: 0
0.530
This error used to occur on `work.ubq.fi` to me often al…
5
content:
  content:
    p:
      score: 0
      elementCount: 3
    img:
      score: 5
      elementCount: 1
    hr:
      score: 0
      elementCount: 1
  result: 5
regex:
  wordCount: 86
  wordValue: 0
  result: 0
0.530
Considering the above two comments, I'm re-opening this for revi…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 22
  wordValue: 0
  result: 0
0.330
I'll catch what I can during reviews in the remaining three PRs …
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 21
  wordValue: 0
  result: 0
0.430
My apologies @rndquu, fixed now
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0
  result: 0
0.230
Sorted @rndquu1. PRs opened in relevant repos: related to #27…
6
content:
  content:
    p:
      score: 0
      elementCount: 4
    ol:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
    img:
      score: 5
      elementCount: 1
  result: 6
regex:
  wordCount: 30
  wordValue: 0
  result: 0
0.630
I merged https://github.com/ubiquity-os-marketplace/ubiquity-os-…
22
content:
  content:
    p:
      score: 0
      elementCount: 6
    img:
      score: 5
      elementCount: 1
    ol:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 4
    ul:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 3
  result: 22
regex:
  wordCount: 60
  wordValue: 0
  result: 0
0.730
Fixed, I had forgot to set `checked` relevant to the inp…
5
content:
  content:
    p:
      score: 0
      elementCount: 4
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 59
  wordValue: 0
  result: 0
0.730

 [ 0.57 WXDAI ] 

@zugdev
Contributions Overview
ViewContributionCountReward
IssueComment10.57
ReviewComment230
Conversation Incentives
CommentFormattingRelevancePriorityReward
I'll take this one as soon as #13 is through.
0.77
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 11
  wordValue: 0.1
  result: 0.77
130.57
This is a duplicate cache set, you already cache manifests insid…
0
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 14
  wordValue: 0
  result: 0
0.830
You have `JSON.parse(localStorage.getItem("manifestCache") |…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 10
  wordValue: 0
  result: 0
0.730
If there is still time we should move buttons outside of table. …
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 44
  wordValue: 0
  result: 0
0.530
redundant cache set here, handleOrgSelection already caches
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 7
  wordValue: 0
  result: 0
0.730
the problem is this addEventListener statement, if only you navi…
5
content:
  content:
    p:
      score: 0
      elementCount: 2
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 32
  wordValue: 0
  result: 0
0.930
typo: space between sentences here
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0
  result: 0
0.630
please use `else if (option === "remove")`, if new optio…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 12
  wordValue: 0
  result: 0
0.830
typo: space between sentences
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 4
  wordValue: 0
  result: 0
0.630
the function isn't being called because it's in a arrow function…
0
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 29
  wordValue: 0
  result: 0
0.730
pressing reset to default is disabling the remove button when it…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 22
  wordValue: 0
  result: 0
0.830
We should only show "no orgs available" after we've looked at th…
5
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 36
  wordValue: 0
  result: 0
0.630
1. Though I've selected an org there is no visual indicator of w…
6
content:
  content:
    ol:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
    p:
      score: 0
      elementCount: 3
    img:
      score: 5
      elementCount: 1
  result: 6
regex:
  wordCount: 35
  wordValue: 0
  result: 0
0.830
These icons are not intuitive, perhaps text is better.![image]…
5
content:
  content:
    p:
      score: 0
      elementCount: 2
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 9
  wordValue: 0
  result: 0
0.530
Some responsiveness issues, not sure if relevant as of this PR:…
5
content:
  content:
    p:
      score: 0
      elementCount: 2
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 11
  wordValue: 0
  result: 0
0.330
json is not vertically expanding for me:https://github.com/use…
5
content:
  content:
    p:
      score: 0
      elementCount: 2
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 7
  wordValue: 0
  result: 0
0.430
Once a plugin config is added, a popup appears to push to GitHub…
10
content:
  content:
    p:
      score: 0
      elementCount: 4
    img:
      score: 5
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 10
regex:
  wordCount: 58
  wordValue: 0
  result: 0
0.730
Cleared cache and is now working smooth, perhaps it was on my en…
0
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 45
  wordValue: 0
  result: 0
0.330
Of course the ideal is to show precisely the ones he can edit. I…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 31
  wordValue: 0
  result: 0
0.530
I can't add conversation rewards plugin with default config, I i…
5
content:
  content:
    p:
      score: 0
      elementCount: 2
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 31
  wordValue: 0
  result: 0
0.930
writeNewConfig executions are accumulating:[accumulating-toast…
10
content:
  content:
    p:
      score: 0
      elementCount: 4
    a:
      score: 5
      elementCount: 2
  result: 10
regex:
  wordCount: 49
  wordValue: 0
  result: 0
0.730
Remove is broken for me, nothing happens when I press it.
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 11
  wordValue: 0
  result: 0
0.830
This is oAuth rate limit.
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0
  result: 0
0.430
Appears like you have solved the problems I found. The only thin…
7
content:
  content:
    p:
      score: 0
      elementCount: 7
    img:
      score: 5
      elementCount: 1
    ol:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 4
  result: 7
regex:
  wordCount: 73
  wordValue: 0
  result: 0
0.530

 [ 300 WXDAI ] 

@rndquu
Contributions Overview
ViewContributionCountReward
IssueSpecification1285.3
IssueComment335.13
ReviewComment7232.284
Conversation Incentives
CommentFormattingRelevancePriorityReward
Depends on https://github.com/ubiquity-os/ubiquity-os-plugin-ins…
31.7
content:
  content:
    p:
      score: 0
      elementCount: 8
    ol:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 6
    a:
      score: 5
      elementCount: 5
  result: 28
regex:
  wordCount: 70
  wordValue: 0.1
  result: 3.7
13285.3
Yes, https://github.com/ubiquity-os/ubiquity-os-plugin-installer…
5.88
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 13
  wordValue: 0.1
  result: 0.88
1317.64
@Keyrxng Notice a new subtask:```6. Add github r…
0.39
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0.1
  result: 0.39
131.17
The bot is not responding because of https://github.com/ubiquity…
5.88
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 13
  wordValue: 0.1
  result: 0.88
0.5316.32
@Keyrxng 1. Getting this error on trying to add the https://gi…
23.64
content:
  content:
    p:
      score: 0
      elementCount: 4
    ol:
      score: 0
      elementCount: 2
    li:
      score: 0.5
      elementCount: 2
    a:
      score: 5
      elementCount: 4
  result: 21
regex:
  wordCount: 47
  wordValue: 0.1
  result: 2.64
0.8369.336
@Keyrxng Check this screenshot:<img width="1511" alt="Scree…
7.64
content:
  content:
    p:
      score: 0
      elementCount: 4
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 47
  wordValue: 0.1
  result: 2.64
0.7320.544
@Keyrxng 1. For some of the plugins (`User activity watche…
14.48
content:
  content:
    p:
      score: 0
      elementCount: 5
    ol:
      score: 0
      elementCount: 2
    li:
      score: 0.5
      elementCount: 2
    a:
      score: 5
      elementCount: 2
  result: 11
regex:
  wordCount: 65
  wordValue: 0.1
  result: 3.48
0.6339.264
Check this screenshot:<img width="1511" alt="Screenshot 202…
7.54
content:
  content:
    p:
      score: 0
      elementCount: 4
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 45
  wordValue: 0.1
  result: 2.54
0.7320.334
1. So, as far as I understand, when https://github.com/ubiquity-…
7.7
content:
  content:
    ol:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
    p:
      score: 0
      elementCount: 2
    a:
      score: 5
      elementCount: 1
  result: 6
regex:
  wordCount: 28
  wordValue: 0.1
  result: 1.7
0.5320.55
I suppose when all of the critical issues are ready (https://git…
16.22
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 3
  result: 15
regex:
  wordCount: 19
  wordValue: 0.1
  result: 1.22
0.4346.464
@Keyrxng Now you could merge the latest `main` branch in…
5.88
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 13
  wordValue: 0.1
  result: 0.88
0.3315.792

 [ 49.668 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
ReviewComment249.668
Conversation Incentives
CommentFormattingRelevancePriorityReward
Seems to work fine although I have a few remarks:- I don't see…
17.08
content:
  content:
    p:
      score: 0
      elementCount: 6
    ul:
      score: 0
      elementCount: 3
    li:
      score: 0.5
      elementCount: 5
    a:
      score: 5
      elementCount: 2
  result: 12.5
regex:
  wordCount: 90
  wordValue: 0.1
  result: 4.58
0.7347.118
I have seen only 2 out of 4 orgs where I am an admin with the ri…
1.7
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 28
  wordValue: 0.1
  result: 1.7
0.532.55

@Keyrxng
Copy link
Contributor

Keyrxng commented Nov 29, 2024

@rndquu $285 for a < 500 char spec (excluding urls) is amazing compared to $300 for implementing it 😂 I need to up my new task game lmao

@rndquu
Copy link
Member Author

rndquu commented Nov 29, 2024

@rndquu $285 for a < 500 char spec (excluding urls) is amazing compared to $300 for implementing it 😂 I need to up my new task game lmao

All text conversation incentive parameters should be fine tuned once the project is transformed into an automated DAO.

@0x4007
Copy link
Member

0x4007 commented Dec 7, 2024

I think we need to remove the priority level multiplier on the spec @gentlementlegen

@gentlementlegen
Copy link
Member

gentlementlegen commented Dec 7, 2024

@0x4007
Copy link
Member

0x4007 commented Dec 7, 2024

As I understand its the priority level thats the problem. Spec should always be a 3x multiplier. Maybe.

@zugdev
Copy link

zugdev commented Dec 7, 2024

As I understand its the priority level thats the problem. Spec should always be a 3x multiplier. Maybe.

I agree, priority should apply to review and implementation, but spec doesn't fit that well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants