-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improvements #19
Comments
I'll take this one as soon as #13 is through. |
It's all good brother I got things under control here, I'm happy to carry on and clear the new tasks prior to merge. I assume you'll be reviewing my PRs which will take up some time and I assume you have more pressing tasks to address anyway like permit rollups etc |
@rndquu Is this certain? Are we deprecating the dev bot instance or is this just in terms of partners? i.e including a less visible method of selecting the dev config for internal use? I figured this would be used for development too as @gentlementlegen had mentioned building something similar for his own use |
Yes, https://github.com/ubiquity-os/ubiquity-os-plugin-installer is for partners. Development config can be created manually at any time. |
@Keyrxng Notice a new subtask:
|
/start |
* feat: default Jest testing configuration * Update .github/workflows/jest-testing.yml * chore: moved jest config from js to ts * chore: removed unused check to trigger Jest Action --------- Co-authored-by: アレクサンダー.eth <[email protected]>
The bot is not responding because of ubiquity-os/ubiquity-os-kernel#195. I'll try to regenerate later. |
+ Evaluating results. Please wait... |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 300 |
Issue | Comment | 2 | 2.88075 |
Review | Comment | 21 | 0 |
Conversation Incentives
Comment | Formatting | Relevance | Priority | Reward |
---|---|---|---|---|
It's all good brother I got things under control here, I'm happy… | 2.97content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 54 wordValue: 0.1 result: 2.97 | 0.5 | 3 | 1.10625 |
@rndquu Is this certain? Are we deprecating the dev bot instance… | 2.97content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 54 wordValue: 0.1 result: 2.97 | 0.8 | 3 | 1.7745 |
Resolves #19Changes:- readme display- production config on… | 6.5content: content: p: score: 0 elementCount: 7 ul: score: 0 elementCount: 1 li: score: 0.5 elementCount: 3 a: score: 5 elementCount: 1 result: 6.5 regex: wordCount: 12 wordValue: 0 result: 0 | 0.8 | 3 | 0 |
Move them to where? I lack the imagination lmao. Perhaps the lit… | 5content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 36 wordValue: 0 result: 0 | 0.7 | 3 | 0 |
This PR became quite long so I will address tests in another tas… | 0content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 27 wordValue: 0 result: 0 | 0.6 | 3 | 0 |
https://docs.github.com/en/rest/orgs/orgs?apiVersion=2022-11-28#… | 6content: content: p: score: 0 elementCount: 8 ul: score: 0 elementCount: 1 li: score: 0.5 elementCount: 2 a: score: 5 elementCount: 1 result: 6 regex: wordCount: 142 wordValue: 0 result: 0 | 0.5 | 3 | 0 |
I couldn't reproduce this pls lmk if it happens again and what y… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 22 wordValue: 0 result: 0 | 0.4 | 3 | 0 |
Any chance you wrote a log to find out as I cannot repro and I d… | 5content: content: p: score: 0 elementCount: 4 img: score: 5 elementCount: 1 result: 5 regex: wordCount: 74 wordValue: 0 result: 0 | 0.3 | 3 | 0 |
They do have text when hovered and were part of 0x4007's origina… | 5content: content: p: score: 0 elementCount: 2 img: score: 5 elementCount: 1 result: 5 regex: wordCount: 40 wordValue: 0 result: 0 | 0.6 | 3 | 0 |
1. That is relevant to https://github.com/ubiquity-os/ubiquity-o… | 11content: content: ol: score: 0 elementCount: 1 li: score: 0.5 elementCount: 2 p: score: 0 elementCount: 5 a: score: 5 elementCount: 2 result: 11 regex: wordCount: 126 wordValue: 0 result: 0 | 0.5 | 3 | 0 |
Resolved here [7bd56ac](https://github.com/ubiquity-os/ubiquity-… | 5content: content: p: score: 0 elementCount: 3 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 54 wordValue: 0 result: 0 | 0.7 | 3 | 0 |
waiting for the team | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0 result: 0 | 0.2 | 3 | 0 |
![image](https://github.com/user-attachments/assets/ade27502-3b4… | 11content: content: p: score: 0 elementCount: 7 img: score: 5 elementCount: 2 ul: score: 0 elementCount: 1 li: score: 0.5 elementCount: 2 hr: score: 0 elementCount: 1 result: 11 regex: wordCount: 99 wordValue: 0 result: 0 | 0.5 | 3 | 0 |
So this UI should display all orgs that the user is an admin of … | 0content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 50 wordValue: 0 result: 0 | 0.6 | 3 | 0 |
Both of those plugins fixed: `pricing` was improperly se… | 10content: content: p: score: 0 elementCount: 7 img: score: 5 elementCount: 1 a: score: 5 elementCount: 1 result: 10 regex: wordCount: 81 wordValue: 0 result: 0 | 0.7 | 3 | 0 |
`rest.orgs.listForUser():`This returns all 4 orgs for … | 0content: content: p: score: 0 elementCount: 5 em: score: 0 elementCount: 1 result: 0 regex: wordCount: 93 wordValue: 0 result: 0 | 0.5 | 3 | 0 |
This error used to occur on `work.ubq.fi` to me often al… | 5content: content: p: score: 0 elementCount: 3 img: score: 5 elementCount: 1 hr: score: 0 elementCount: 1 result: 5 regex: wordCount: 86 wordValue: 0 result: 0 | 0.5 | 3 | 0 |
Considering the above two comments, I'm re-opening this for revi… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 22 wordValue: 0 result: 0 | 0.3 | 3 | 0 |
I'll catch what I can during reviews in the remaining three PRs … | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 21 wordValue: 0 result: 0 | 0.4 | 3 | 0 |
My apologies @rndquu, fixed now | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0 result: 0 | 0.2 | 3 | 0 |
Sorted @rndquu1. PRs opened in relevant repos: related to #27… | 6content: content: p: score: 0 elementCount: 4 ol: score: 0 elementCount: 1 li: score: 0.5 elementCount: 2 img: score: 5 elementCount: 1 result: 6 regex: wordCount: 30 wordValue: 0 result: 0 | 0.6 | 3 | 0 |
I merged https://github.com/ubiquity-os-marketplace/ubiquity-os-… | 22content: content: p: score: 0 elementCount: 6 img: score: 5 elementCount: 1 ol: score: 0 elementCount: 1 li: score: 0.5 elementCount: 4 ul: score: 0 elementCount: 1 a: score: 5 elementCount: 3 result: 22 regex: wordCount: 60 wordValue: 0 result: 0 | 0.7 | 3 | 0 |
Fixed, I had forgot to set `checked` relevant to the inp… | 5content: content: p: score: 0 elementCount: 4 img: score: 5 elementCount: 1 result: 5 regex: wordCount: 59 wordValue: 0 result: 0 | 0.7 | 3 | 0 |
[ 0.57 WXDAI ]
@zugdev
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 0.57 |
Review | Comment | 23 | 0 |
Conversation Incentives
Comment | Formatting | Relevance | Priority | Reward |
---|---|---|---|---|
I'll take this one as soon as #13 is through. | 0.77content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 11 wordValue: 0.1 result: 0.77 | 1 | 3 | 0.57 |
This is a duplicate cache set, you already cache manifests insid… | 0content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 14 wordValue: 0 result: 0 | 0.8 | 3 | 0 |
You have `JSON.parse(localStorage.getItem("manifestCache") |… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 10 wordValue: 0 result: 0 | 0.7 | 3 | 0 |
If there is still time we should move buttons outside of table. … | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 44 wordValue: 0 result: 0 | 0.5 | 3 | 0 |
redundant cache set here, handleOrgSelection already caches | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 7 wordValue: 0 result: 0 | 0.7 | 3 | 0 |
the problem is this addEventListener statement, if only you navi… | 5content: content: p: score: 0 elementCount: 2 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 32 wordValue: 0 result: 0 | 0.9 | 3 | 0 |
typo: space between sentences here | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0 result: 0 | 0.6 | 3 | 0 |
please use `else if (option === "remove")`, if new optio… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 12 wordValue: 0 result: 0 | 0.8 | 3 | 0 |
typo: space between sentences | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0 result: 0 | 0.6 | 3 | 0 |
the function isn't being called because it's in a arrow function… | 0content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 29 wordValue: 0 result: 0 | 0.7 | 3 | 0 |
pressing reset to default is disabling the remove button when it… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 22 wordValue: 0 result: 0 | 0.8 | 3 | 0 |
We should only show "no orgs available" after we've looked at th… | 5content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 36 wordValue: 0 result: 0 | 0.6 | 3 | 0 |
1. Though I've selected an org there is no visual indicator of w… | 6content: content: ol: score: 0 elementCount: 1 li: score: 0.5 elementCount: 2 p: score: 0 elementCount: 3 img: score: 5 elementCount: 1 result: 6 regex: wordCount: 35 wordValue: 0 result: 0 | 0.8 | 3 | 0 |
These icons are not intuitive, perhaps text is better.![image]… | 5content: content: p: score: 0 elementCount: 2 img: score: 5 elementCount: 1 result: 5 regex: wordCount: 9 wordValue: 0 result: 0 | 0.5 | 3 | 0 |
Some responsiveness issues, not sure if relevant as of this PR:… | 5content: content: p: score: 0 elementCount: 2 img: score: 5 elementCount: 1 result: 5 regex: wordCount: 11 wordValue: 0 result: 0 | 0.3 | 3 | 0 |
json is not vertically expanding for me:https://github.com/use… | 5content: content: p: score: 0 elementCount: 2 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 7 wordValue: 0 result: 0 | 0.4 | 3 | 0 |
Once a plugin config is added, a popup appears to push to GitHub… | 10content: content: p: score: 0 elementCount: 4 img: score: 5 elementCount: 1 a: score: 5 elementCount: 1 result: 10 regex: wordCount: 58 wordValue: 0 result: 0 | 0.7 | 3 | 0 |
Cleared cache and is now working smooth, perhaps it was on my en… | 0content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 45 wordValue: 0 result: 0 | 0.3 | 3 | 0 |
Of course the ideal is to show precisely the ones he can edit. I… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 31 wordValue: 0 result: 0 | 0.5 | 3 | 0 |
I can't add conversation rewards plugin with default config, I i… | 5content: content: p: score: 0 elementCount: 2 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 31 wordValue: 0 result: 0 | 0.9 | 3 | 0 |
writeNewConfig executions are accumulating:[accumulating-toast… | 10content: content: p: score: 0 elementCount: 4 a: score: 5 elementCount: 2 result: 10 regex: wordCount: 49 wordValue: 0 result: 0 | 0.7 | 3 | 0 |
Remove is broken for me, nothing happens when I press it. | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 11 wordValue: 0 result: 0 | 0.8 | 3 | 0 |
This is oAuth rate limit. | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0 result: 0 | 0.4 | 3 | 0 |
Appears like you have solved the problems I found. The only thin… | 7content: content: p: score: 0 elementCount: 7 img: score: 5 elementCount: 1 ol: score: 0 elementCount: 1 li: score: 0.5 elementCount: 4 result: 7 regex: wordCount: 73 wordValue: 0 result: 0 | 0.5 | 3 | 0 |
[ 300 WXDAI ]
@rndquu
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 285.3 |
Issue | Comment | 3 | 35.13 |
Review | Comment | 7 | 232.284 |
Conversation Incentives
Comment | Formatting | Relevance | Priority | Reward |
---|---|---|---|---|
Depends on https://github.com/ubiquity-os/ubiquity-os-plugin-ins… | 31.7content: content: p: score: 0 elementCount: 8 ol: score: 0 elementCount: 1 li: score: 0.5 elementCount: 6 a: score: 5 elementCount: 5 result: 28 regex: wordCount: 70 wordValue: 0.1 result: 3.7 | 1 | 3 | 285.3 |
Yes, https://github.com/ubiquity-os/ubiquity-os-plugin-installer… | 5.88content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 13 wordValue: 0.1 result: 0.88 | 1 | 3 | 17.64 |
@Keyrxng Notice a new subtask:```6. Add github r… | 0.39content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39 | 1 | 3 | 1.17 |
The bot is not responding because of https://github.com/ubiquity… | 5.88content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 13 wordValue: 0.1 result: 0.88 | 0.5 | 3 | 16.32 |
@Keyrxng 1. Getting this error on trying to add the https://gi… | 23.64content: content: p: score: 0 elementCount: 4 ol: score: 0 elementCount: 2 li: score: 0.5 elementCount: 2 a: score: 5 elementCount: 4 result: 21 regex: wordCount: 47 wordValue: 0.1 result: 2.64 | 0.8 | 3 | 69.336 |
@Keyrxng Check this screenshot:<img width="1511" alt="Scree… | 7.64content: content: p: score: 0 elementCount: 4 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 47 wordValue: 0.1 result: 2.64 | 0.7 | 3 | 20.544 |
@Keyrxng 1. For some of the plugins (`User activity watche… | 14.48content: content: p: score: 0 elementCount: 5 ol: score: 0 elementCount: 2 li: score: 0.5 elementCount: 2 a: score: 5 elementCount: 2 result: 11 regex: wordCount: 65 wordValue: 0.1 result: 3.48 | 0.6 | 3 | 39.264 |
Check this screenshot:<img width="1511" alt="Screenshot 202… | 7.54content: content: p: score: 0 elementCount: 4 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 45 wordValue: 0.1 result: 2.54 | 0.7 | 3 | 20.334 |
1. So, as far as I understand, when https://github.com/ubiquity-… | 7.7content: content: ol: score: 0 elementCount: 1 li: score: 0.5 elementCount: 2 p: score: 0 elementCount: 2 a: score: 5 elementCount: 1 result: 6 regex: wordCount: 28 wordValue: 0.1 result: 1.7 | 0.5 | 3 | 20.55 |
I suppose when all of the critical issues are ready (https://git… | 16.22content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 3 result: 15 regex: wordCount: 19 wordValue: 0.1 result: 1.22 | 0.4 | 3 | 46.464 |
@Keyrxng Now you could merge the latest `main` branch in… | 5.88content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 13 wordValue: 0.1 result: 0.88 | 0.3 | 3 | 15.792 |
[ 49.668 WXDAI ]
@gentlementlegen
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Review | Comment | 2 | 49.668 |
Conversation Incentives
Comment | Formatting | Relevance | Priority | Reward |
---|---|---|---|---|
Seems to work fine although I have a few remarks:- I don't see… | 17.08content: content: p: score: 0 elementCount: 6 ul: score: 0 elementCount: 3 li: score: 0.5 elementCount: 5 a: score: 5 elementCount: 2 result: 12.5 regex: wordCount: 90 wordValue: 0.1 result: 4.58 | 0.7 | 3 | 47.118 |
I have seen only 2 out of 4 orgs where I am an admin with the ri… | 1.7content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 28 wordValue: 0.1 result: 1.7 | 0.5 | 3 | 2.55 |
@rndquu $285 for a < 500 char spec (excluding urls) is amazing compared to $300 for implementing it 😂 I need to up my new task game lmao |
All text conversation incentive parameters should be fine tuned once the project is transformed into an automated DAO. |
I think we need to remove the priority level multiplier on the spec @gentlementlegen |
As I understand its the priority level thats the problem. Spec should always be a 3x multiplier. Maybe. |
I agree, priority should apply to review and implementation, but spec doesn't fit that well |
Depends on #13
What should be done:
The text was updated successfully, but these errors were encountered: