Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated eslint to use flat-config file #6

Merged
merged 12 commits into from
Jun 19, 2024
Merged

feat: updated eslint to use flat-config file #6

merged 12 commits into from
Jun 19, 2024

Conversation

gentlementlegen
Copy link
Member

Resolves #5

@gentlementlegen
Copy link
Member Author

gentlementlegen commented Jun 18, 2024 •
edited
Loading

What changed

  • pinned package versions to avoid (bad) surprises
  • bumped eslint to v9, updated config file accordingly
  • small code changes related to changes in the configuration
  • removed logger files since logs should come from https://github.com/ubiquity/ubiquibot-logger
  • added validation on environment and settings, returning an appropriate error with details
  • clean up so Knip is green
  • added release-please as it is quite important for Actions so people can use tags

@ubiquity-os ubiquity-os deleted a comment from github-actions bot Jun 18, 2024
@ubiquity-os ubiquity-os deleted a comment from github-actions bot Jun 18, 2024
@gentlementlegen gentlementlegen marked this pull request as ready for review June 18, 2024 16:46
Keyrxng
Keyrxng reviewed Jun 18, 2024
View reviewed changes
README.md Show resolved Hide resolved
Keyrxng
Keyrxng reviewed Jun 18, 2024
View reviewed changes
package.json Show resolved Hide resolved
@ubiquity-os ubiquity-os deleted a comment from github-actions bot Jun 18, 2024
0x4007
0x4007 reviewed Jun 18, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
0x4007
0x4007 reviewed Jun 18, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@ubiquity-os ubiquity-os deleted a comment from github-actions bot Jun 18, 2024
@gentlementlegen gentlementlegen requested a review from 0x4007 June 18, 2024 22:25
0x4007
0x4007 reviewed Jun 18, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@ubiquity-os ubiquity-os deleted a comment from github-actions bot Jun 19, 2024
@gentlementlegen gentlementlegen requested a review from 0x4007 June 19, 2024 06:56
@0x4007 0x4007 merged commit 2e98ddf into ubiquity-os:main Jun 19, 2024
1 of 3 checks passed
@ubiquibot ubiquibot bot mentioned this pull request Jun 19, 2024
Closed
@gentlementlegen gentlementlegen deleted the feat/eslint-flat-config branch June 19, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keyrxng Keyrxng Keyrxng approved these changes

@0x4007 0x4007 0x4007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update eslint to v9
3 participants
@gentlementlegen @0x4007 @Keyrxng