Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint to v9 #5

Closed
gentlementlegen opened this issue Jun 18, 2024 · 4 comments · Fixed by #6
Closed

Update eslint to v9 #5

gentlementlegen opened this issue Jun 18, 2024 · 4 comments · Fixed by #6

Comments

@gentlementlegen
Copy link
Member

We are using an old version of eslint which differs in the way of how the configuration is defined. A new format called flat format is now in used, and has benefits like having a fully type supported typescript check within the configuration. It would be nice to benefit from that upgrade for the new plugins.

References:
https://eslint.org/docs/latest/use/migrate-to-9.0.0
https://typescript-eslint.io/getting-started

Copy link

ubiquibot bot commented Jun 19, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Jun 19, 2024

[ 91.7 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueSpecification117.8
IssueTask125
ReviewComment132.6
ReviewComment116.3
Conversation Incentives
CommentFormattingRelevanceReward
We are using an old version of `eslint` which differs in...
17.8
code:
  count: 3
  score: "3"
  words: 4
117.8
## What changed - pinned package versions to avoid (bad) surpri...
32.6
h2:
  count: 1
  score: "2"
  words: 2
li:
  count: 7
  score: "14"
  words: 73
code:
  count: 1
  score: "2"
  words: 1
0.6632.6
## What changed - pinned package versions to avoid (bad) surpri...
16.3
h2:
  count: 1
  score: "1"
  words: 2
li:
  count: 7
  score: "7"
  words: 73
code:
  count: 1
  score: "1"
  words: 1
0.6616.3

@0x4007
Copy link
Member

0x4007 commented Jun 19, 2024

I guess the rewards calculation for the pull comments are very broken this time @gentlementlegen

When v2?

@gentlementlegen
Copy link
Member Author

@0x4007 Seems v2 went on a break as well, I do not see anymore logs. Might be because it's not using the main branch for deployments (I think I sent you a message about this). Waiting of start | stop then good to go.
ubiquity-os-marketplace/command-start-stop#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants