-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: waiting message is displayed at the beginning of the run #52
feat: waiting message is displayed at the beginning of the run #52
Conversation
# Conflicts: # package.json # yarn.lock
QA run : Meniole#6 (comment) Since this is not a Worker, when I first implemented the message it would appear for around 1 second before being updated with the results. That's because the script itself takes ~1s to execute. So what I did instead is posting the waiting message directly at the beginning of the workflow through a script, which then would appear directly after the cold boot of the worker (~10s) which was the fastest I could display it, without a worker. Any other ideas are welcome. |
Polling is a possibility given the long max run time It may even be the most robust way to post a timeout error message |
@0x4007 The problem is not polling but cold boot + package install before being able to run a script. I was able to only be delayed by cold boot using scripting directly into the action file. |
I don't understand your comment but just poll for like 30 minutes and then can write an error if the permits comment is not found. |
cd752b7
into
ubiquity-os-marketplace:development
Resolves #29