Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post a waiting message to show that the conversation is being processed #29

Closed
gentlementlegen opened this issue Jun 2, 2024 · 11 comments · Fixed by #52
Closed

Post a waiting message to show that the conversation is being processed #29

gentlementlegen opened this issue Jun 2, 2024 · 11 comments · Fixed by #52

Comments

@gentlementlegen
Copy link
Member

The current bot would display:

+ Evaluating results. Please wait...

while the content is being processed. However, it would post a second comment with the result. In this version ideally it would just post the comment once, and update it with the final result.

Tasks to be carried out:

  • display a waiting message when the workflow starts
  • update that same comment with the final result
  • add related tests

Example run
#25 (comment)

@Sadaf-A
Copy link

Sadaf-A commented Jun 9, 2024

/start

Copy link

ubiquibot bot commented Jun 9, 2024

DeadlineSun, Jun 9, 3:13 PM UTC
Registered Wallet 0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@gentlementlegen
Copy link
Member Author

@Sadaf-A Please provide an update.

@0x4007
Copy link
Member

0x4007 commented Jul 10, 2024

Mixed feelings funding this task. We should only be working on v2

@gentlementlegen
Copy link
Member Author

@0x4007 Not sure to understand, this is a v2 task, for the conversation rewards?

Copy link

ubiquibot bot commented Jul 11, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot-dev bot commented Jul 11, 2024

[ 58.46 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Task 1 50
Issue Specification 1 7.9
Issue Comment 2 0.56
Conversation Incentives
Comment Formatting Relevance Reward
The current bot would display: ``` + Evaluating resu…
7.9
content:
  p:
    count: 74
    score: 1
  code:
    count: 5
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 7.9
@Sadaf-A Please provide an update.
1
content:
  p:
    count: 5
    score: 1
wordValue: 0.2
formattingMultiplier: 1
- -
@0x4007 Not sure to understand, this is a v2 task, for the conve…
2.8
content:
  p:
    count: 14
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.2 0.56

[ 0 WXDAI ]

@Sadaf-A
Contributions Overview
View Contribution Count Reward
Conversation Incentives
Comment Formatting Relevance Reward

[ 0 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 1 0
Conversation Incentives
Comment Formatting Relevance Reward
Mixed feelings funding this task. We should only be working on v2
1.2
content:
  p:
    count: 12
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -

Copy link

ubiquibot bot commented Jul 11, 2024

[ 7.2 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment11.2
ReviewComment26
Conversation Incentives
CommentFormattingRelevanceReward
Mixed feelings funding this task. We should only be working on v...
1.20.231.2
> QA run : https://github.com/Meniole/conversation-rewards/is...
3.4
hr:
  count: 1
  score: "1"
  words: 0
0.483.4
> @0x4007 The problem is not polling but cold boot + package ...
2.60.42.6

[ 116.1 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueSpecification119.8
IssueTask150
IssueComment24
IssueComment20
ReviewComment228.2
ReviewComment214.1
Conversation Incentives
CommentFormattingRelevanceReward
The current bot would display: ``` + Evaluating re...
19.8
li:
  count: 3
  score: "3"
  words: 19
code:
  count: 1
  score: "1"
  words: 0
119.8
@Sadaf-A Please provide an update....
1.20.221.2
@0x4007 Not sure to understand, this is a v2 task, for the conve...
2.80.092.8
@Sadaf-A Please provide an update....
-0.22-
@0x4007 Not sure to understand, this is a v2 task, for the conve...
-0.09-
QA run : https://github.com/Meniole/conversation-rewards/issues/...
21.2
hr:
  count: 1
  score: "2"
  words: 0
0.821.2
@0x4007 The problem is not polling but cold boot + package insta...
70.257
QA run : https://github.com/Meniole/conversation-rewards/issues/...
10.6
hr:
  count: 1
  score: "1"
  words: 0
0.810.6
@0x4007 The problem is not polling but cold boot + package insta...
3.50.253.5

@0x4007
Copy link
Member

0x4007 commented Jul 11, 2024

[ 58.46 WXDAI ]

@gentlementlegen

[ 0 WXDAI ]

@Sadaf-A

[ 0 WXDAI ]

@0x4007
Contributions Overview

View Contribution Count Reward
Issue Comment 1 0

Conversation Incentives

Comment Formatting Relevance Reward

Mixed feelings funding this task. We should only be working on v2

1.2

@gentlementlegen v2 doesn't load the pull comments.

@gentlementlegen
Copy link
Member Author

@0x4007 It seems so. I added this result for debug in issue #26

@gentlementlegen
Copy link
Member Author

[ 181.02 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Task 1 50
Issue Specification 1 7.1
Issue Comment 3 5.12
Review Comment 9 118.8
Conversation Incentives
Comment Formatting Relevance Reward
The current bot would display: ``` + Evaluating re…
7.1
content:
  p:
    count: 44
    score: 1
  pre:
    count: 5
    score: 0
  code:
    count: 5
    score: 1
  ul:
    count: 22
    score: 0
  li:
    count: 22
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 7.1
@Sadaf-A Please provide an update.
1
content:
  p:
    count: 5
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.8 0.8
@0x4007 Not sure to understand, this is a v2 task, for the conve…
2.8
content:
  p:
    count: 14
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.8 2.24
@0x4007 It seems so. I added this result for debug in issue http…
2.6
content:
  p:
    count: 13
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.8 2.08
Resolves #29 <!-- - You must link the issue number e.g. "R…
0
content:
  p:
    count: 3
    score: 1
  ul:
    count: 18
    score: 0
  li:
    count: 18
    score: 1
wordValue: 0
formattingMultiplier: 0
0.8 -
Was required for an import within a test. Removed it and changed…
6
content:
  p:
    count: 15
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 6
This is what I did at first but running a script requires: - clo…
37.2
content:
  p:
    count: 12
    score: 1
  ul:
    count: 81
    score: 0
  li:
    count: 81
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 37.2
@rndquu Was not removed the diff is misleading: https://github.c…
3.6
content:
  p:
    count: 9
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 3.6
It does not anymore afaik. Its only purpose is to create a `…
14.8
content:
  p:
    count: 36
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 14.8
Will add a comment describing what this does to make it more cle…
5.2
content:
  p:
    count: 13
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 5.2
Let me know if that helps https://github.com/ubiquibot/conversa…
2.8
content:
  p:
    count: 7
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 2.8
QA run : https://github.com/Meniole/conversation-rewards/issues/…
34.8
content:
  h2:
    count: 4
    score: 1
  p:
    count: 83
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 34.8
@0x4007 The problem is not polling but cold boot + package insta…
14.4
content:
  p:
    count: 36
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 14.4

[ 14.02 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 2 1.52
Review Comment 5 12.5
Conversation Incentives
Comment Formatting Relevance Reward
Mixed feelings funding this task. We should only be working on v2
1.2
content:
  p:
    count: 12
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.8 0.96
@gentlementlegen v2 doesn't load the pull comments.
0.7
content:
  p:
    count: 7
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.8 0.56
What's this for
0.3
content:
  p:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 0.3
It seems to make more sense to write all the logic inside of typ…
6.5
content:
  p:
    count: 65
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 6.5
Let's try this approach then. I understand now.
0.8
content:
  p:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 0.8
Polling is a possibility given the long max run time It may eve…
2.4
content:
  p:
    count: 24
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.4
I don't understand your comment but just poll for like 30 minute…
2.5
content:
  p:
    count: 25
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.5

[ 7.5 WXDAI ]

@rndquu
Contributions Overview
View Contribution Count Reward
Review Comment 3 7.5
Conversation Incentives
Comment Formatting Relevance Reward
@gentlementlegen This was really useful, at least I used this st…
2.6
content:
  p:
    count: 26
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.6
@gentlementlegen Right now this package writes all of the log en…
2.1
content:
  p:
    count: 20
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.1
This is not super clear that `process.env.COMMENT_ID` is…
2.8
content:
  p:
    count: 26
    score: 1
  code:
    count: 1
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants