-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add appropriate entities to showcase modal notifications #226
base: master
Are you sure you want to change the base?
feat: Add appropriate entities to showcase modal notifications #226
Conversation
Folks, This PR is a very welcome sight -- it was on my personal TODO list. Some changes I think we should make:
|
Sure thing
What did you have in mind @drewwills ? |
I'll take a stab... Student Portal UpdatesWelcome to the new student portal based on |
…odal Includes updated modal notification (replaces lorem ipsum)
This is where c23c1ae puts us Had to use NotificationPortlet-4.2.0 as NotificationPortlet-4.3.x was throwing erroring with a regenerator runtime error Also, the modal doesn't render in Firefox |
uPortal-Project/NotificationPortlet#114 appears to be what we would need to make this happen. Is that right? |
That's correct @jonathanmtran. I have code (from a uP implementation project) that's about a 95% match. I think @bjagg also has some very similar code. One of us can probably post a PR for that feature soonish. |
Yes, I can have a PR in a few days for uPortal-Project/NotificationPortlet#114 |
@bjagg is uPortal-Project/NotificationPortlet#114 still on the roadmap? |
Checklist
Description of change
https://github.com/Jasig/NotificationPortlet/blob/master/notification-portlet-webapp/docs/modal.md
TODO