Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regeneratorRuntime is not defined #116

Closed
jonathanmtran opened this issue Oct 4, 2018 · 9 comments
Closed

regeneratorRuntime is not defined #116

jonathanmtran opened this issue Oct 4, 2018 · 9 comments
Labels

Comments

@jonathanmtran
Copy link

Describe the bug
A regeneratorRuntime is not defined is preventing the modal notification from rendering

To Reproduce

  1. Deploy portlet with a modal notification web component such as feat: Add appropriate entities to showcase modal notifications uPortal-start#226
  2. Open developer tools
  3. Navigate to the page containing the modal notification web component

Expected behavior
A notification modal

Screenshots
screenshot from 2018-10-04 14-33-13

screenshot from 2018-10-04 14-32-43

Platform:

  • Notification Portlet Version: 4.3.1
  • Browser: Chrome/ium and Firefox
@ChristianMurphy
Copy link
Member

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Oct 4, 2018

Looking into this now 🔍

@ChristianMurphy
Copy link
Member

@jonathanmtran a work around is adding <script src="https://unpkg.com/[email protected]/runtime.js"></script>
uPortal-Project/uPortal-web-components#117 will probably be the long term fix to prevent this from coming up again as new components get added.

@jonathanmtran
Copy link
Author

Adding <script src="https://unpkg.com/[email protected]/runtime.js"></script> works for Chrome/ium
On the other hand, the modal doesn't render on Firefox

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Oct 4, 2018

@ChristianMurphy
Copy link
Member

Is it still happening in 4.3.1 on your system?

@jonathanmtran
Copy link
Author

@ChristianMurphy Yes. I've deployed 4.3.1 and it still doesn't render/appear on Firefox

@ChristianMurphy
Copy link
Member

@jonathanmtran I tested this with uPortal 5.3.0 and a snapshot of the master branch of this repo (soon to be officially released).
I'm seeing it work on Chrome, Firefox, and Edge.

Let me know if you run into any other issues, we could hop on a video call and debug.

@ChristianMurphy
Copy link
Member

Notification portlet 4.4.0 includes the fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants