upgraded to purescript 0.12 #4
Conversation
|
hmm not sure why it's breaking on Travis. Tests pass on my machine :) I'll take a look this weekend. As an side I was unhappy with the insert performance when using this lib (I'm inserting millions of data points). I did some profiling and some benchmarking against pure JS. Long story short, a 3x speedup can be achieved if the "onsuccess" function is not set on a transaction and only "oncomplete" is used. Not sure if/how/should this fits in this lib. Also as another aside - very impressed with your work on this! Usually I avoid wrapper libraries, but this one is quite good. Question for you: how do you make your code formatting so uniform? It's really a joy to work with! |
| import Data.Enum (toEnum) | ||
| import Data.Maybe (Maybe(..), isNothing, maybe) | ||
| import Data.Array (head, drop) | ||
| import Data.Time.Duration (Milliseconds(..)) | ||
| import Data.Traversable (traverse) | ||
| import Data.Tuple (Tuple(..), uncurry) | ||
| import Test.Spec (describe, describeOnly, it) | ||
| import Test.Spec (describe, it) |
There was a problem hiding this comment.
This line is not indented like the surrounding code.
| name' `shouldEqual` name | ||
| tearDown name version db02 | ||
|
|
||
|
I just took a look since I'm interested in using this library on 0.12 myself. It looks really great 👍 I left a few comments only about formatting. |
|
I'll try to have a look at it during the week guys 👍 |
|
well I just upgraded this to 0.13.2 The test run and pass on my machine. They fail in travis because a username/password is required to run Firefox and Chrome. |
No description provided.