Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for psc 0.13 #5

Open
mjepronk opened this issue Oct 24, 2019 · 6 comments
Open

Support for psc 0.13 #5

mjepronk opened this issue Oct 24, 2019 · 6 comments

Comments

@mjepronk
Copy link

mjepronk commented Oct 24, 2019

There already is a pull request #4 to merge support for version 0.12/0.13 of the PureScript compiler. Is there any reason that this isn't merged?
Also, would be nice if this package could be added to the package-sets.
P.S. If you would be like to give up maintenance of this package I'm willing take it over.

@btrepp
Copy link

btrepp commented Nov 24, 2019

I've had a play and the branch in #4 (with converting purescript-spec-mocha to have packagesets)
works well with "psc-0.13.4-20191110" package set. All the tests from the fork pass, at least in chrome.

It would be great to be able to have this library available for this toolset :)

@KtorZ
Copy link
Contributor

KtorZ commented Nov 24, 2019

@zwilias I clearly don't have time to maintain this package, I am not so much involved with PureScript anymore and I am not really willing to to be honest 😅 ...

I am not sure if TruQu ended up using this in the end, I know quite a few things have changed regarding the product strategy but, if no one is maintaining this package at TruQu anymore, perhaps giving its maintenance away to @mjepronk could be a good idea?

Thoughts?

@mjepronk
Copy link
Author

@KtorZ Thanks for your response.

@zwilias
Copy link

zwilias commented Nov 29, 2019

I think that sounds good!

Thanks for the time and effort you've put into this, @KtorZ!

@mjepronk: I'll go ahead and give you access to this repository.

@mjepronk
Copy link
Author

mjepronk commented Dec 1, 2019

@zwilias: Thanks! I'm going to merge the PR's coming week.

@caryoscelus
Copy link

it seems that @ilyakooo0 's fork supports modern tooling, though i haven't checked whether anything logic-wise got broken yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants