Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix the type definition of additionalJVMConfig #154

Merged

Conversation

heitorrbarros
Copy link
Member

No description provided.

Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash both commits. You could also use a more descriptive commit message, maybe something like:

Fix default value for additionalJVMConfig 

`additionalJVMConfig` expects a list, so the default value should not be an empty object.

`additionalJVMConfig` expects a list, so the default value should not be an empty object.
@heitorrbarros heitorrbarros force-pushed the fix-additional-jvm-config-type branch from 63c9d44 to 950e338 Compare May 10, 2024 13:44
@heitorrbarros
Copy link
Member Author

Please squash both commits. You could also use a more descriptive commit message, maybe something like:

Fix default value for additionalJVMConfig 

`additionalJVMConfig` expects a list, so the default value should not be an empty object.

Ok, done 950e338

Thanks @nineinchnick

@nineinchnick nineinchnick merged commit 3239a09 into trinodb:main May 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants