Cannot overwrite table with non table for trino.coordinator.additionalJVMConfig and for trino.worker.additionalJVMConfig

[adityatanwar03]

Hi i think the additionalJVMConfig parameter in the values.yaml should be additionalJVMConfig : [ ] instead of additionalJVMConfig: { } which is producing this error / bug when doing helm install and upgrade

Values i am using the additionalJVMConfig parameter :

coordinator:
  additionalJVMConfig:
    -  -Djava.security.auth.login.config=/etc/trino/config-files/conf.jaas
    -  -Djava.security.krb5.conf=/etc/trino/config-files/krb5.conf

Error / bug i am getting :

coalesce.go:286: warning: cannot overwrite table with non table for trino.coordinator.additionalJVMConfig (map[])

Result : Despite of the above message the configmap is creating properly

Tasks

Beta Give feedback

No tasks being tracked yet.

[heitorrbarros]

Hi @adityatanwar03!

I noticed that there might be a small issue with the type definition of trino.coordinator.additional JVM Config. To fix this, simply replace it with an array of strings, and your upgrade should work smoothly.

Would you mind testing it with the following values?

coordinator:
  additionalJVMConfig:
    - "-Djava.security.auth.login.config=/etc/trino/config-files/conf.jaas"
    - "-Djava.security.krb5.conf=/etc/trino/config-files/krb5.conf"

I crafted a PR for fix it: #154

[adityatanwar03]

@heitorrbarros In the first run it didnt showed any warning / error but after that again it started showing those warnings.

root@prgx-lab-ctl-plane-00028b76-b578v:~# helm upgrade -f values.yaml example-trino-cluster trino/trino
coalesce.go:286: warning: cannot overwrite table with non table for trino.coordinator.additionalJVMConfig (map[])
coalesce.go:286: warning: cannot overwrite table with non table for trino.worker.additionalJVMConfig (map[])
Release "example-trino-cluster" has been upgraded. Happy Helming!
NAME: example-trino-cluster
LAST DEPLOYED: Fri Apr 19 10:43:51 2024
NAMESPACE: default
STATUS: deployed
REVISION: 68
TEST SUITE: None
NOTES:
Get the application URL by running these commands:
  export POD_NAME=$(kubectl get pods --namespace default -l "app=trino,release=example-trino-cluster,component=coordinator" -o jsonpath="{.items[0].metadata.name}")
  echo "Visit http://127.0.0.1:8080 to use your application"
  kubectl port-forward $POD_NAME 8080:8080

the override-values.yaml i am using looks like this

image:
  tag: "413"

additionalConfigProperties:
  - spill-enabled=true
  - spiller-spill-path=/tmp/spill

server:
  workers: 2
  node:
    environment: prgxlab


coordinator:
  additionalJVMConfig:
    - "-Djava.security.auth.login.config=/etc/trino/config-files/conf.jaas"
    - "-Djava.security.krb5.conf=/etc/trino/config-files/krb5.conf"
  secretMounts:
    - name: config-files
      secretName: config-files
      path: /etc/trino/config-files
    - name: keytab-files
      secretName: keytab-files
      path: /etc/trino/keytab-files
  resources:
    limits:
      cpu: "1"
      memory: "3Gi"
    requests:
      cpu: "500m"
      memory: "2Gi"

worker:
  additionalJVMConfig:
    - "-Djava.security.auth.login.config=/etc/trino/config-files/conf.jaas"
    - "-Djava.security.krb5.conf=/etc/trino/config-files/krb5.conf"
  secretMounts:
    - name: config-files
      secretName: config-files
      path: /etc/trino/config-files
    - name: keytab-files
      secretName: keytab-files
      path: /etc/trino/keytab-files
  resources:
    limits:
      cpu: "4"
      memory: "10Gi"
    requests:
      cpu: "2"
      memory: "5Gi"

[nineinchnick]

#154 has been merged, so I'll close this. Feel free to reopen if you're still seeing these warnings on a fresh install.