Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: use snapshots for basic tests for nano devices #117

Merged
merged 18 commits into from
Nov 14, 2023
Merged

Tests: use snapshots for basic tests for nano devices #117

merged 18 commits into from
Nov 14, 2023

Conversation

spalmer25
Copy link
Collaborator

fixes #111

@spalmer25 spalmer25 added app::wallet issues relating to the wallet app tests test - related isues device::NANOS Issues affecting NANOS device device::NANOSP Issues affecting NANOSP device device::NANOX Issues affecting NANOX device labels Nov 9, 2023
@spalmer25 spalmer25 self-assigned this Nov 9, 2023
@spalmer25 spalmer25 force-pushed the palmer@functori@snapshots-for-basic-tests-for-nano-devices branch from e997b9d to 696961c Compare November 9, 2023 14:37
emturner
emturner reviewed Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@emturner emturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall I think this makes sense? It does get rid of the check_section_text.py stuff from the basic tests IIUC - is that likely to be an issue at all?

@spalmer25 spalmer25 marked this pull request as ready for review November 9, 2023 16:33
@spalmer25 spalmer25 force-pushed the palmer@functori@snapshots-for-basic-tests-for-nano-devices branch 3 times, most recently from b67282b to ff21917 Compare November 13, 2023 12:46
@spalmer25 spalmer25 force-pushed the palmer@functori@snapshots-for-basic-tests-for-nano-devices branch 2 times, most recently from b13bd7b to 9c1558c Compare November 13, 2023 15:01
@spalmer25 spalmer25 requested a review from emturner November 13, 2023 15:30
@spalmer25 spalmer25 force-pushed the palmer@functori@snapshots-for-basic-tests-for-nano-devices branch from 864be7a to d103979 Compare November 14, 2023 07:34
emturner
emturner approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@emturner emturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@spalmer25 spalmer25 merged commit f21f487 into main Nov 14, 2023
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emturner emturner emturner approved these changes

Assignees

@spalmer25 spalmer25

Labels
app::wallet issues relating to the wallet app device::NANOS Issues affecting NANOS device device::NANOSP Issues affecting NANOSP device device::NANOX Issues affecting NANOX device tests test - related isues
Projects
None yet
Milestone
Wallet: v3.0.0 - ledger feeback
Development

Successfully merging this pull request may close these issues.

Nano: use snapshots for basic tests
2 participants
@spalmer25 @emturner