Tests: fix parsing error tests on Nanox

trilitech · Nov 9, 2023 · e997b9d · e997b9d
1 parent d51b8dd
commit e997b9d
Show file tree

Hide file tree

Showing 35 changed files with 13 additions and 1 deletion.
diff --git a/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00000.png b/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00000.png
diff --git a/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00001.png b/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00001.png
diff --git a/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00002.png b/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00002.png
diff --git a/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00003.png b/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00003.png
diff --git a/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00004.png b/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00004.png
diff --git a/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00005.png b/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00005.png
diff --git a/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00006.png b/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00006.png
diff --git a/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00007.png b/...on/nano/snapshots/nanox/test_parsing_errors/one_byte_added_at_the_end/00007.png
diff --git a/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00000.png b/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00000.png
diff --git a/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00001.png b/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00001.png
diff --git a/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00002.png b/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00002.png
diff --git a/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00003.png b/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00003.png
diff --git a/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00004.png b/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00004.png
diff --git a/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00005.png b/...ration/nano/snapshots/nanox/test_parsing_errors/one_byte_added_inside/00005.png
diff --git a/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00000.png b/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00000.png
diff --git a/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00001.png b/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00001.png
diff --git a/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00002.png b/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00002.png
diff --git a/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00003.png b/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00003.png
diff --git a/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00004.png b/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00004.png
diff --git a/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00005.png b/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00005.png
diff --git a/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00006.png b/...tion/nano/snapshots/nanox/test_parsing_errors/one_byte_removed_inside/00006.png
diff --git a/...egration/nano/snapshots/nanox/test_parsing_errors/unknown_magic_bytes/00000.png b/...egration/nano/snapshots/nanox/test_parsing_errors/unknown_magic_bytes/00000.png
diff --git a/...ntegration/nano/snapshots/nanox/test_parsing_errors/unknown_operation/00000.png b/...ntegration/nano/snapshots/nanox/test_parsing_errors/unknown_operation/00000.png
diff --git a/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00000.png b/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00000.png
diff --git a/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00001.png b/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00001.png
diff --git a/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00002.png b/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00002.png
diff --git a/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00003.png b/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00003.png
diff --git a/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00004.png b/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00004.png
diff --git a/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00005.png b/...ntegration/nano/snapshots/nanox/test_parsing_errors/wrong_last_packet/00005.png
diff --git a/tests/integration/nano/snapshots/nanox/test_too_deep/00000.png b/tests/integration/nano/snapshots/nanox/test_too_deep/00000.png
diff --git a/tests/integration/nano/snapshots/nanox/test_too_large/00000.png b/tests/integration/nano/snapshots/nanox/test_too_large/00000.png
diff --git a/tests/integration/nano/test_parsing_errors.py b/tests/integration/nano/test_parsing_errors.py
@@ -31,41 +31,47 @@ def make_path(name: str) -> Path:
         app.parsing_error_signing(DEFAULT_ACCOUNT,
                                   "0100000000000000000000000000000000000000000000000000000000000000006c016e8874874d31c3fbd636e924d5a036a43ec8faa7d0860308362d80d30e01000000000000000000000000000000000000000000ff02000000020316",
                                   with_hash=True,
+                                  text="INVALID_TAG",
                                   path=make_path("unknown_magic_bytes"))
 
         app.assert_screen(Screen.Home)
 
         app.parsing_error_signing(DEFAULT_ACCOUNT,
                                   "03000000000000000000000000000000000000000000000000000000000000000001016e8874874d31c3fbd636e924d5a036a43ec8faa7d0860308362d80d30e01000000000000000000000000000000000000000000ff02000000020316",
                                   with_hash=True,
+                                  text="INVALID_TAG",
                                   path=make_path("unknown_operation"))
 
         app.assert_screen(Screen.Home)
 
         app.parsing_error_signing(DEFAULT_ACCOUNT,
                                   "0300000000000000000000000000000000000000000000000000000000000000006c016e8874874d31c3fbd636e924d5a036a43ec8faa7d0860308362d80d30e010000000000000000000000000000000000000000ff02000000020316",
                                   with_hash=True,
+                                  text="INVALID_TAG",
                                   path=make_path("one_byte_removed_inside"))
 
         app.assert_screen(Screen.Home)
 
         app.parsing_error_signing(DEFAULT_ACCOUNT,
                                   "0300000000000000000000000000000000000000000000000000000000000000006c016e8874874d31c3fbd636e924d5a036a43ec8faa7d0860308362d80d30e01000000000000000000000000000000000000000000ff0200000002031645",
                                   with_hash=True,
+                                  text="INVALID_TAG",
                                   path=make_path("one_byte_added_at_the_end"))
 
         app.assert_screen(Screen.Home)
 
         app.parsing_error_signing(DEFAULT_ACCOUNT,
                                   "0300000000000000000000000000000000000000000000000000000000000000006c016e8874874d31c3fbd636e924d5a036a43ec8faa7d0860308362d80d30e0100000000000000000000000000000000000000000000ff02000000020316",
                                   with_hash=True,
+                                  text="INVALID_TAG",
                                   path=make_path("one_byte_added_inside"))
 
         app.assert_screen(Screen.Home)
 
         app.parsing_error_signing(DEFAULT_ACCOUNT,
                                   "0300000000000000000000000000000000000000000000000000000000000000006c016e8874874d31c3fbd636e924d5a036a43ec8faa7d0860308362d80d30e0100000000000000000000000000000000000000000000ff02000000020316",
                                   with_hash=True,
+                                  text="INVALID_TAG",
                                   path=make_path("one_byte_added_inside"))
 
         app.assert_screen(Screen.Home)

diff --git a/tests/integration/nano/test_too_deep.py b/tests/integration/nano/test_too_deep.py
@@ -27,6 +27,7 @@
         app.parsing_error_signing(DEFAULT_ACCOUNT,
                                   "0502000000f702000000f202000000ed02000000e802000000e302000000de02000000d902000000d402000000cf02000000ca02000000c502000000c002000000bb02000000b602000000b102000000ac02000000a702000000a2020000009d02000000980200000093020000008e02000000890200000084020000007f020000007a02000000750200000070020000006b02000000660200000061020000005c02000000570200000052020000004d02000000480200000043020000003e02000000390200000034020000002f020000002a02000000250200000020020000001b020000001602000000",
                                   with_hash=True,
+                                  text="TOO_DEEP",
                                   path=test_name)
 
         app.quit()
diff --git a/tests/integration/nano/test_too_large.py b/tests/integration/nano/test_too_large.py
@@ -27,6 +27,7 @@
         app.parsing_error_signing(DEFAULT_ACCOUNT,
                                   "050092abf8e3d9e5f8cfd9ae8a9fe5f28ea1d5b5abf1af82dae8a4b68df3d1889eb6f988f5e8d31a",
                                   with_hash=True,
+                                  text="TOO_LARGE",
                                   path=test_name)
 
         app.quit()
diff --git a/tests/integration/nano/utils/app.py b/tests/integration/nano/utils/app.py
@@ -335,11 +335,15 @@ def parsing_error_signing(self,
                               account: Account,
                               message: Union[str, bytes],
                               with_hash: bool,
+                              text: str,
                               path: Union[str, Path]) -> None:
+        if self.backend.firmware.device != "nanox":
+            text = "Parsing error"
+
         self._failing_signing(account,
                               message,
                               with_hash,
-                              "Parsing error",
+                              text,
                               StatusCode.PARSE_ERROR,
                               path)