Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base58 encoding from ledger SDK #58

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Use base58 encoding from ledger SDK #58

merged 3 commits into from
Mar 4, 2024

Conversation

ajinkyaraj-23
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 commented Mar 1, 2024 •
edited
Loading

fixes #46

@ajinkyaraj-23 ajinkyaraj-23 added this to the Baking app upgrade milestone Mar 1, 2024
@ajinkyaraj-23 ajinkyaraj-23 requested a review from spalmer25 March 1, 2024 16:36
@ajinkyaraj-23 ajinkyaraj-23 self-assigned this Mar 1, 2024
@ajinkyaraj-23 ajinkyaraj-23 linked an issue Mar 1, 2024 that may be closed by this pull request
Use SDK base58_encoder instead of our own #46
Closed
@ajinkyaraj-23 ajinkyaraj-23 changed the title - Use base58 encoding from ledger SDK WIP - Use base58 encoding from ledger SDK Mar 1, 2024
@spalmer25 spalmer25 force-pushed the ajinkyaraj-23@use_base58_from_sdk branch from f1fd7a0 to 71dc7a1 Compare March 4, 2024 08:31
@spalmer25 spalmer25 force-pushed the ajinkyaraj-23@use_base58_from_sdk branch from 71dc7a1 to bba3c8a Compare March 4, 2024 08:33
@spalmer25 spalmer25 changed the title WIP - Use base58 encoding from ledger SDK Use base58 encoding from ledger SDK Mar 4, 2024
@spalmer25 spalmer25 force-pushed the ajinkyaraj-23@use_base58_from_sdk branch from f738b05 to 9f524a4 Compare March 4, 2024 08:44
spalmer25
spalmer25 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@spalmer25 spalmer25 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've written below what I've modified so that you can review your own PR.

spalmer25
spalmer25 approved these changes Mar 4, 2024
View reviewed changes
src/main.c Show resolved Hide resolved
src/globals.h Show resolved Hide resolved
src/globals.c Show resolved Hide resolved
misra.json Show resolved Hide resolved
spalmer25
spalmer25 approved these changes Mar 4, 2024
View reviewed changes
src/globals.h Show resolved Hide resolved
@ajinkyaraj-23
Copy link
Collaborator Author

I've written below what I've modified so that you can review your own PR.

Excellent. Now it works.

@ajinkyaraj-23 ajinkyaraj-23 merged commit 34d1c53 into main Mar 4, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmer25 spalmer25 spalmer25 approved these changes

Assignees

@spalmer25 spalmer25

@ajinkyaraj-23 ajinkyaraj-23

Labels
new-baking-app
Projects
None yet
Milestone
Baking app upgrade
Development

Successfully merging this pull request may close these issues.

Use SDK base58_encoder instead of our own
2 participants
@ajinkyaraj-23 @spalmer25