Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SDK base58_encoder instead of our own #46

Closed
ajinkyaraj-23 opened this issue Feb 23, 2024 · 0 comments · Fixed by #58
Closed

Use SDK base58_encoder instead of our own #46

ajinkyaraj-23 opened this issue Feb 23, 2024 · 0 comments · Fixed by #58
Assignees
@spalmer25 @ajinkyaraj-23
Labels
new-baking-app
Milestone
Baking app upgrade

Comments

@ajinkyaraj-23
Copy link
Collaborator

Ledger SDK provides base58_encoder which makes base58_encoding.h implementation in the app redundant. Use the SDK version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spalmer25 spalmer25

@ajinkyaraj-23 ajinkyaraj-23

Labels
new-baking-app
Projects
None yet
Milestone
Baking app upgrade
Development

Successfully merging a pull request may close this issue.

Use base58 encoding from ledger SDK trilitech/ledger-app-tezos-baking
2 participants
@spalmer25 @ajinkyaraj-23