Fix minor issues like NULL pointer check #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ajinkyaraj-23
commented
Apr 22, 2024
ajinkyaraj-23
commented
- Add assert conditions while accessing baking_key in apdu_query.c
- Refactor: change magic numbers to constant macros for better readability.
- Refactor: Fix or Remove all TODO's
- Fix null pointer checks as pre-conditions for functions in to_string.c
- Fix issues with pytest environment.
1. Avoid buffer overflow by adding check on length for bip32_path.components array access. 2. Refactor derivation type check with standard TZ_ASSERT .
Refactor unreachable code in TZ_ASSERT as condition was always true even if there is an error code in write_highwatermark
ajinkyaraj-23
force-pushed
the
105-fix-minor-issues-with-code
branch
6 times, most recently
from
68160ab to
ce58567
Compare
spalmer25
reviewed
Apr 23, 2024
ajinkyaraj-23
force-pushed
the
105-fix-minor-issues-with-code
branch
3 times, most recently
from
bd8aec8 to
fca5d8e
Compare
spalmer25
reviewed
Apr 23, 2024
ajinkyaraj-23
force-pushed
the
105-fix-minor-issues-with-code
branch
from
fca5d8e to
e9fc2ba
Compare
Use pre-defined macro SAFE_STRLCPY to avoid repetition.
ajinkyaraj-23
force-pushed
the
105-fix-minor-issues-with-code
branch
from
e9fc2ba to
f07f208
Compare
spalmer25
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.