New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor issues with code #105

Closed

ajinkyaraj-23 opened this issue Apr 22, 2024 · 0 comments · Fixed by #108

Assignees

Labels

Milestone

Baking app upgrade

Collaborator

ajinkyaraj-23 commented Apr 22, 2024

Add to Src/apdu_query.c :81 before resp[offset] = length;

TZ_ASSERT(length <= NUM_ELEMENTS(g_hwm.baking_key.bip32_path.components),
EXC_WRONG_LENGTH);
Src/apdu_query.c:100 repititive code
Src/key.c:90,108 magic numbers
Src/operations.c:175 parse_z
Src/type.h:214 remove todo
Null pointer check
BLIND signing reply on email, update [APDU.md](http://APDU.md)

ajinkyaraj-23 added the new-baking-app label

ajinkyaraj-23 added this to the Baking app upgrade milestone

ajinkyaraj-23 self-assigned this

ajinkyaraj-23 linked a pull request

that will close this issue

Fix minor issues like NULL pointer check #108

Merged

ajinkyaraj-23 closed this as completed in #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment