Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Django 4.2 #219

Closed
wants to merge 3 commits into from
Closed

Conversation

simkimsia
Copy link
Contributor

@simkimsia simkimsia commented Apr 2, 2023

Description

In tox.ini:

  • Replace whitelist_externals with allowlist_externals because whitelist_externals is deprecated
  • Added isolated_build = True
  • Remove install_command where it calls tox_install.sh
  • Drop tool.poetry.dev-dependencies and switch to using tool.poetry.extras in order for tox to detect them

In ci.yml

  • Because now use tool.poetry.extras so when call poetry install need to incldue —extras ‘test’ as argument

The last 2 points about dropping dev-dependencies and using extras are from https://github.com/orgs/python-poetry/discussions/4307#discussioncomment-1041658

Fixes #212, #214, #215, #216, #218

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

In tox.ini:

- Replace whitelist_externals with allowlist_externals because whitelist_externals is deprecated
- Added isolated_build = True
- Remove install_command where it calls tox_install.sh
- Drop tool.poetry.dev-dependencies and switch to using tool.poetry.extras in order for tox to detect them

In ci.yml
- Because now use tool.poetry.extras so when call `poetry install` need to incldue `—extras ‘test’` as argument

The last 2 points about dropping dev-dependencies and using extras are from https://github.com/orgs/python-poetry/discussions/4307#discussioncomment-1041658

Fixes torchbox#212, torchbox#214, torchbox#215, torchbox#216, torchbox#218
@simkimsia simkimsia mentioned this pull request Apr 2, 2023
8 tasks
@simkimsia
Copy link
Contributor Author

This is the cleaned up version of PR #213

I hope this can be accepted despite completely changing the way the tox and poetry coexists from the previous way.

If this is accepted, my next PR would be to remove tox_install.sh completely

Thank you.

@simkimsia
Copy link
Contributor Author

simkimsia commented Apr 2, 2023

@thibaudcolas or @bcdickinson can help to review this PR? Thank you

Update

Ignore this since I'm closing this in favor of #220

@simkimsia
Copy link
Contributor Author

#221 is a better issue for this and
#220 is a less invasive, more targeted PR than this

@simkimsia simkimsia closed this Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Django 4.2
1 participant