Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: using tox_install.sh doesn't seem highly conventional. Can switch to a different way? #221

Open
simkimsia opened this issue Apr 2, 2023 · 2 comments

Comments

@simkimsia
Copy link
Contributor

simkimsia commented Apr 2, 2023

Is your proposal related to a problem?

While trying to solve #212, i discover issues when trying to upgrade the tox.ini which was using whitelist_internals, a deprecated keyword.

Sent me on a tangent and wrote a drastically different way in PR #219

In order to adopt more conventional ways of using both tox with poetry, shall we try a different way?

Issues related: #214, #215, #216, #218

Describe the solution you'd like

#219 removes tox_install.sh and tool.poetry.dev-dependencies in pyproject.toml altogether in favor of using tool.poetry.extras instead.

Another alternative is to use https://pypi.org/project/tox-poetry-installer/

@bcdickinson
Copy link

bcdickinson commented Apr 4, 2023

Hi @simkimsia, tox_install.sh is relic from before I knew tox-poetry existed. As that project is now deprecated in favour of Poetry's built-in support, I think the way forward here is to follow the Poetry docs and drop tox_install.sh.

PS - thanks for showing an interest in this project and submitting issues and PRs, I'll try and get round to reviewing them as soon as I can!

@simkimsia
Copy link
Contributor Author

Thank you @bcdickinson

Lmk how I can help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants