Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: tox.ini is outdated and other related issues #218

Closed
simkimsia opened this issue Apr 2, 2023 · 1 comment
Closed

ci: tox.ini is outdated and other related issues #218

simkimsia opened this issue Apr 2, 2023 · 1 comment

Comments

@simkimsia
Copy link
Contributor

Related issues:

  1. tox no longer supports whitelist_externals See Docs: whitelist_externals was replaced by allowlist_externals python-poetry/poetry#7341 for details
  2. tox cannot detect tool.poetry.dev-dependencies, so the solution adopted is to use tool.poetry.extras instead. Drawback is whenever use poetry install in the normal poetry virtual environment an extra call to poetry install --extras 'test' is required. See https://github.com/orgs/python-poetry/discussions/4307#discussioncomment-1041658 for details
  3. Recommend that tox_install.sh to be deleted, but this is not necessary for now.

This is related to #214, #215, #216.

Detected when trying to solve #212 and #213
simkimsia added a commit to simkimsia/django-pattern-library that referenced this issue Apr 2, 2023
@simkimsia
Update tox.ini and pyproject.toml because tox upgraded
376a577 
In tox.ini:

- Replace whitelist_externals with allowlist_externals because whitelist_externals is deprecated
- Added isolated_build = True
- Remove install_command where it calls tox_install.sh
- Drop tool.poetry.dev-dependencies and switch to using tool.poetry.extras in order for tox to detect them

In ci.yml
- Because now use tool.poetry.extras so when call `poetry install` need to incldue `—extras ‘test’` as argument

The last 2 points about dropping dev-dependencies and using extras are from https://github.com/orgs/python-poetry/discussions/4307#discussioncomment-1041658

Fixes torchbox#212, torchbox#214, torchbox#215, torchbox#216, torchbox#218
This was referenced Apr 2, 2023
Closed
Open
Merged
@zerolab
Copy link
Member

zerolab commented Oct 18, 2024

Fixed in #220

@zerolab zerolab closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zerolab @simkimsia